feat(transaction-controller): add instant transaction support#8248
Draft
matthewwalsh0 wants to merge 12 commits intomainfrom
Draft
feat(transaction-controller): add instant transaction support#8248matthewwalsh0 wants to merge 12 commits intomainfrom
matthewwalsh0 wants to merge 12 commits intomainfrom
Conversation
…ator for instant transactions
Also fix ready guards in speedUp/cancel to use #getTransaction (nullable) instead of #getTransactionOrThrow to preserve existing behavior for unknown transaction IDs.
…and data stage Extract addTransaction and startTransaction into lifecycle/pipeline.ts with a dedicated data stage in lifecycle/stages/data.ts. Encapsulate all branching logic into individual getters, convert fire-and-forget chains to async/await, and unify instant and non-instant flows through the same pipeline.
Remove instant option from addTransaction in favour of dedicated startTransaction method. Extract validation into reusable functions, move pipeline types to lifecycle/types.ts, deduplicate shared setup into createTransaction, alphabetise TransactionContext, and remove premature ready check in approveTransaction.
matthewwalsh0
force-pushed
the
feat/instant-transaction
branch
from
ac4c0bd to
5cb0e9e
Compare
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Add
startTransactionmethod toTransactionControllerfor synchronous transaction creation with deferred async data resolution.References
Checklist