Skip to content

chore(ramps-controller): replace Sinon with Jest fake timers#7973

Merged
cryptodev-2s merged 3 commits intomainfrom
chore/ramps-controller-replace-sinon-with-jest
Feb 18, 2026
Merged

chore(ramps-controller): replace Sinon with Jest fake timers#7973
cryptodev-2s merged 3 commits intomainfrom
chore/ramps-controller-replace-sinon-with-jest

Conversation

@cryptodev-2s
Copy link
Contributor

@cryptodev-2s cryptodev-2s commented Feb 18, 2026

Explanation

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Low Risk
Test-only changes plus devDependency reshuffling; no production runtime logic is modified, but timer behavior differences could cause minor test flakiness.

Overview
Updates RampsService.test.ts and TransakService.test.ts to use Jest fake timers (jest.useFakeTimers, jest.runAllTimersAsync, jest.advanceTimersByTimeAsync, jest.advanceTimersToNextTimerAsync) instead of Sinon’s useFakeTimers/clock.

Cleans up dependencies by removing sinon/@types/sinon from @metamask/ramps-controller devDependencies (and yarn.lock), while adding @types/sinon to @metamask/network-controller devDependencies to satisfy repo-wide typing needs.

Written by Cursor Bugbot for commit c2a3293. This will update automatically on new commits. Configure here.

@cryptodev-2s cryptodev-2s force-pushed the chore/ramps-controller-replace-sinon-with-jest branch 2 times, most recently from 1144d33 to 8e7fd3b Compare February 18, 2026 17:25
@cryptodev-2s cryptodev-2s force-pushed the chore/ramps-controller-replace-sinon-with-jest branch from 8e7fd3b to adf9a57 Compare February 18, 2026 17:32
"@types/jest-when": "^2.7.3",
"@types/lodash": "^4.14.191",
"@types/node-fetch": "^2.6.12",
"@types/sinon": "^9.0.10",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added this here to prevent CI from failing (see the run: https://github.com/MetaMask/core/actions/runs/22150534022/job/64040402496); otherwise it would be dropped entirely from the lockfile.

@cryptodev-2s cryptodev-2s marked this pull request as ready for review February 18, 2026 18:21
@cryptodev-2s cryptodev-2s requested review from a team as code owners February 18, 2026 18:21
Copy link
Contributor

@amitabh94 amitabh94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for Ramps!

@cryptodev-2s cryptodev-2s added this pull request to the merge queue Feb 18, 2026
Merged via the queue into main with commit 87e2a77 Feb 18, 2026
310 checks passed
@cryptodev-2s cryptodev-2s deleted the chore/ramps-controller-replace-sinon-with-jest branch February 18, 2026 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments