chore(ramps-controller): replace Sinon with Jest fake timers#7973
Merged
cryptodev-2s merged 3 commits intomainfrom Feb 18, 2026
Merged
chore(ramps-controller): replace Sinon with Jest fake timers#7973cryptodev-2s merged 3 commits intomainfrom
cryptodev-2s merged 3 commits intomainfrom
Conversation
1144d33 to
8e7fd3b
Compare
8e7fd3b to
adf9a57
Compare
cryptodev-2s
commented
Feb 18, 2026
| "@types/jest-when": "^2.7.3", | ||
| "@types/lodash": "^4.14.191", | ||
| "@types/node-fetch": "^2.6.12", | ||
| "@types/sinon": "^9.0.10", |
Contributor
Author
There was a problem hiding this comment.
Added this here to prevent CI from failing (see the run: https://github.com/MetaMask/core/actions/runs/22150534022/job/64040402496); otherwise it would be dropped entirely from the lockfile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
References
Checklist
Note
Low Risk
Test-only changes plus devDependency reshuffling; no production runtime logic is modified, but timer behavior differences could cause minor test flakiness.
Overview
Updates
RampsService.test.tsandTransakService.test.tsto use Jest fake timers (jest.useFakeTimers,jest.runAllTimersAsync,jest.advanceTimersByTimeAsync,jest.advanceTimersToNextTimerAsync) instead of Sinon’suseFakeTimers/clock.Cleans up dependencies by removing
sinon/@types/sinonfrom@metamask/ramps-controllerdevDependencies (andyarn.lock), while adding@types/sinonto@metamask/network-controllerdevDependencies to satisfy repo-wide typing needs.Written by Cursor Bugbot for commit c2a3293. This will update automatically on new commits. Configure here.