Skip to content

chore: TransactionPoller cleanup#7866

Merged
jpuri merged 1 commit intomainfrom
poller_cleanup
Feb 9, 2026
Merged

chore: TransactionPoller cleanup#7866
jpuri merged 1 commit intomainfrom
poller_cleanup

Conversation

@jpuri
Copy link
Contributor

@jpuri jpuri commented Feb 9, 2026

Explanation

Small transaction poller cleanup PR. Discussion here: #7822 (comment)

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Medium Risk
Changes when websocket-driven polling is triggered, which could increase polling or cause unintended refreshes if unrelated transaction update events match pending hashes.

Overview
TransactionPoller no longer filters AccountActivityService:transactionUpdated events by chain ID (CAIP-2 conversion) or by the selected account address; it now triggers a poll for any confirmed/dropped/failed event whose transaction.id matches a pending transaction hash.

Tests were updated to reflect the relaxed filtering (simpler messenger mock, removed non-matching chain/account cases, and adjusted expectations/descriptions).

Written by Cursor Bugbot for commit cd0baa2. This will update automatically on new commits. Configure here.

@jpuri jpuri requested a review from a team as a code owner February 9, 2026 10:18

const isPendingTransaction = this.#pendingTransactions?.some(
(tx) => tx.hash?.toLowerCase() === transaction.id.toLowerCase(),
);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are checking for pending transactions, other check are redundant.

@jpuri jpuri enabled auto-merge February 9, 2026 11:09
@jpuri jpuri added this pull request to the merge queue Feb 9, 2026
Merged via the queue into main with commit d5e2d99 Feb 9, 2026
304 of 306 checks passed
@jpuri jpuri deleted the poller_cleanup branch February 9, 2026 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments