Conversation
jpuri
commented
Feb 9, 2026
|
|
||
| const isPendingTransaction = this.#pendingTransactions?.some( | ||
| (tx) => tx.hash?.toLowerCase() === transaction.id.toLowerCase(), | ||
| ); |
Contributor
Author
There was a problem hiding this comment.
Since we are checking for pending transactions, other check are redundant.
matthewwalsh0
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Small transaction poller cleanup PR. Discussion here: #7822 (comment)
References
Checklist
Note
Medium Risk
Changes when websocket-driven polling is triggered, which could increase polling or cause unintended refreshes if unrelated transaction update events match pending hashes.
Overview
TransactionPollerno longer filtersAccountActivityService:transactionUpdatedevents by chain ID (CAIP-2 conversion) or by the selected account address; it now triggers a poll for anyconfirmed/dropped/failedevent whosetransaction.idmatches a pending transactionhash.Tests were updated to reflect the relaxed filtering (simpler messenger mock, removed non-matching chain/account cases, and adjusted expectations/descriptions).
Written by Cursor Bugbot for commit cd0baa2. This will update automatically on new commits. Configure here.