refactor: replace sinon with Jest timers and mocks#7796
Closed
cryptodev-2s wants to merge 3 commits intomainfrom
Closed
refactor: replace sinon with Jest timers and mocks#7796cryptodev-2s wants to merge 3 commits intomainfrom
cryptodev-2s wants to merge 3 commits intomainfrom
Conversation
0089112 to
9c74ff5
Compare
Remove sinon from devDependencies in packages where it was declared but not actually used: - app-metadata-controller - approval-controller - core-backend - selected-network-controller
Migrate all test files from sinon fake timers to Jest fake timers and manual time control pattern for async test compatibility.
Migrate from sinon fake timers to Jest fake timers. For the onDegraded test that measures actual elapsed time, use real timers with a lower threshold to keep the test fast.
9c74ff5 to
b5c27a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Replace sinon with Jest timers and mocks
References
Checklist