Skip to content

merge queue: embarking main (1b711ca) and #1322 together#1337

Closed
mergify[bot] wants to merge 2 commits into
mainfrom
mergify/merge-queue/9e78119003
Closed

merge queue: embarking main (1b711ca) and #1322 together#1337
mergify[bot] wants to merge 2 commits into
mainfrom
mergify/merge-queue/9e78119003

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify Bot commented May 4, 2026 •
edited
Loading

🎉 This pull request has been checked successfully and will be merged soon. 🎉

Branch main (1b711ca) and #1322 are embarked together for merge.

This pull request has been created by Mergify to speculatively check the mergeability of #1322.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.

Required conditions of queue rule default for merge:

Required conditions to stay in the queue:

---
checking_base_sha: 1b711caef0aebeed3bbc188af314faeaa46a488e
previous_failed_batches: []
pull_requests:
  - number: 1322
    scopes: []
scopes: []
...

jd and others added 2 commits May 4, 2026 09:38
@jd
chore(python): drop config validate/simulate Python code, now native …
231a98b 
…in Rust

`config validate` (#1282) and `config simulate` (#1298) ship native
in the Rust binary. With the maturin wheel from the previous commit,
both routes resolve to the Rust dispatch — the Python implementations
are dead code, just waiting to drift out of sync with the Rust copy.

Per the post-port plan agreed during review, every command's Python
copy is removed in the same change that makes it releasable as a
single Rust source. For commands already merged before the rule was
adopted, this commit catches them up:

- Delete `mergify_cli/config/` package (cli.py, validate.py).
- Delete `mergify_cli/tests/config/` (the 18 Python tests for
  validate/simulate; the Rust crate's 24 tests cover the same surface
  plus extras).
- Drop the two `[[command]]` entries from `PORT_STATUS.toml` —
  the inventory test only needs to track *Python* commands, and
  these are no longer Python.
- Trim the cross-command exit-code contract suite of its three
  config-related cases; the Rust crate enforces those exit codes
  natively.
- Drop the `from mergify_cli.config import cli as config_cli_mod`
  import + matching `cli.add_command(...)` from the root Python CLI;
  with no Python config commands left, the `config` group disappears
  from the click tree (the Rust binary intercepts before any click
  group lookup, so end-users see no behavior change).

The wheel still builds, installs, and runs both `mergify config
validate` (Rust native) and `mergify --help` (Python shim). 592 of
the previous 610 Python tests pass; the missing 18 are the deleted
config tests.

Change-Id: Ic88170ca01430b62fb98df9aa5fd8e644bdb6e09
@mergify
Merge of #1322
0c28fd7
@mergify mergify Bot deployed to Mergify Merge Protections May 4, 2026 11:06 Active
@mergify mergify Bot mentioned this pull request May 4, 2026
Merged
@mergify mergify Bot closed this May 4, 2026
@mergify mergify Bot deleted the mergify/merge-queue/9e78119003 branch May 4, 2026 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jd