merge queue: embarking main (a91b74d) and #1280 together#1306
Closed
mergify[bot] wants to merge 2 commits intomainfrom
Closed
merge queue: embarking main (a91b74d) and #1280 together#1306mergify[bot] wants to merge 2 commits intomainfrom
mergify[bot] wants to merge 2 commits intomainfrom
Conversation
Populates ``mergify-core`` with the three type-system pieces every ported command will depend on: - ``exit_code::ExitCode`` — typed mirror of Python's ``ExitCode`` enum with the locked numeric values from docs/exit-codes.md. Code 2 is reserved for clap argument errors, matching Python's Click reservation. - ``error::CliError`` — top-level error enum with deterministic ``exit_code()`` mapping. Today it covers Configuration, InvalidState, StackNotFound, Conflict, Generic, and Io variants; HTTP and Git variants land alongside their implementations in 1.2b / 1.2d. - ``output::Output`` trait + ``StdioOutput`` impl — commands emit through a trait object so the ``--json`` vs human rendering decision is a single place (stdout purity invariant from Phase 0.3 enforced by construction). Tests capture output via ``Arc<Mutex<Vec<u8>>>`` sinks. Deferred to separate PRs so each is reviewable in isolation: - 1.2b ``mergify-core::http`` — reqwest wrapper, retry, typed errors - 1.2c colored/spinner affordances on top of ``StdioOutput`` - 1.2d ``GitOps`` trait (only needed for stack commands) - Config loading, interactive prompts — added as ported commands demand them 7 unit tests cover the locked exit-code values, the ``CliError -> ExitCode`` mapping, and the JSON/human split. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Change-Id: If50b81bb5d0accf1d80c25dc14ed259b30135895
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 This pull request has been checked successfully and will be merged soon. 🎉
Branch main (a91b74d) and #1280 are embarked together for merge.
This pull request has been created by Mergify to speculatively check the mergeability of #1280.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue rule
defaultfor merge:title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?:#approved-reviews-by>=2author = dependabot[bot]author = mergify-ci-botauthor = renovate[bot]body ~= (?ms:.{48,})#changes-requested-reviews-by = 0#review-requested = 0#review-threads-unresolved = 0check-success=ci-gateRequired conditions to stay in the queue:
base=mainlabel!=manual mergetitle ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?:#approved-reviews-by>=2author = dependabot[bot]author = mergify-ci-botauthor = renovate[bot]body ~= (?ms:.{48,})#changes-requested-reviews-by = 0#review-requested = 0#review-threads-unresolved = 0check-success=ci-gate