fix(ci): write empty string to GITHUB_OUTPUT when base is undetected#1225
Merged
mergify[bot] merged 1 commit intomainfrom Apr 20, 2026
Conversation
Member
Author
|
This pull request is part of a Mergify stack:
|
Contributor
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 🤖 Continuous IntegrationWonderful, this rule succeeded.
🟢 👀 Review RequirementsWonderful, this rule succeeded.
🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 🔎 ReviewsWonderful, this rule succeeded.
🟢 📕 PR descriptionWonderful, this rule succeeded.
|
jd
previously approved these changes
Apr 20, 2026
Base automatically changed from
devs/sileht/git-refs-better/add-format-text-shell-json-ci-git-refs--10e0ba97
to
main
April 20, 2026 10:12
Contributor
|
@sileht this pull request is now in conflict 😩 |
Previously `maybe_write_to_github_outputs` emitted the literal string `base=None` when base was None (e.g. `workflow_dispatch` events), which leaks Python's `None` representation into workflow output. Coalesce to an empty string so GitHub Actions steps see `base=` instead — consistent with the new `--format=shell` behavior. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Change-Id: I25fe7c86a7c7d2aa823ef2e0fd5e71946892c7d2
sileht
force-pushed
the
devs/sileht/git-refs-better/write-empty-string-github-output-base-undetected--25fe7c86
branch
from
720dfc9 to
188ef73
Compare
Member
Author
Revision history
|
jd
approved these changes
Apr 20, 2026
kozlek
approved these changes
Apr 20, 2026
Contributor
Merge Queue Status
This pull request spent 5 minutes 8 seconds in the queue, including 4 minutes 40 seconds running CI. Required conditions to merge
|
36 tasks
mergify
Bot
deleted the
devs/sileht/git-refs-better/write-empty-string-github-output-base-undetected--25fe7c86
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously
maybe_write_to_github_outputsemitted the literal stringbase=Nonewhen base was None (e.g.workflow_dispatchevents), whichleaks Python's
Nonerepresentation into workflow output. Coalesce toan empty string so GitHub Actions steps see
base=instead — consistentwith the new
--format=shellbehavior.Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com