Skip to content

Remove "Time" from the updated design summary#622

Open
LittleBeannie wants to merge 3 commits intomainfrom
616-remove-time-from-the-updated-design-gt-summary-table
Open

Remove "Time" from the updated design summary#622
LittleBeannie wants to merge 3 commits intomainfrom
616-remove-time-from-the-updated-design-gt-summary-table

Conversation

@LittleBeannie
Copy link
Copy Markdown
Collaborator

@LittleBeannie LittleBeannie commented Apr 29, 2026 •
edited
Loading

To solve issue #616

@LittleBeannie LittleBeannie linked an issue Apr 29, 2026 that may be closed by this pull request
Remove "Time" from the updated design gt-summary table #616
Open
@LittleBeannie
Copy link
Copy Markdown
Collaborator Author

LittleBeannie commented Apr 30, 2026

Hi @jdblischak, we encountered an error in gs_bound_summary. Could you please help with that?

jdblischak
jdblischak reviewed Apr 30, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@jdblischak jdblischak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error non-numeric argument to mathematical function occurs for the line time_value <- round(analysis$time[i], tdigits) in gs_bound_summary_single() after running gs_update_ahr() with a new alpha value:

gsDesign2/R/gs_bound_summary.R

Line 85 in 24492c6

time_value <- round(analysis$time[i], tdigits)

This is because time was removed the data frame analysis returned by gs_update_ahr().

Do you also want to remove the Time from the table produced by gs_bound_summary()? If not, the tests can be fixed by adding back time to the output from gs_update_ahr().

Comment thread R/gs_update_ahr.R
@LittleBeannie
Copy link
Copy Markdown
Collaborator Author

LittleBeannie commented Apr 30, 2026

The error non-numeric argument to mathematical function occurs for the line time_value <- round(analysis$time[i], tdigits) in gs_bound_summary_single() after running gs_update_ahr() with a new alpha value:

gsDesign2/R/gs_bound_summary.R

Line 85 in 24492c6

time_value <- round(analysis$time[i], tdigits)

This is because time was removed the data frame analysis returned by gs_update_ahr().

Do you also want to remove the Time from the table produced by gs_bound_summary()? If not, the tests can be fixed by adding back time to the output from gs_update_ahr().

"Time" is not reported for returns from gs_update_ahr().
"Time" is reported for returns from gs_design_xxx(), gs_power_xxx(), and fixed_design_xxx().

@jdblischak
Only include Time in gs_bound_summary() table if it is available
1ff3537 
Time is no longer returned by gs_update_ahr(). This is relevant
when a user runs gs_bound_summary() directly on the output of
gs_update_ahr(), or if they provide multiple alphas to gs_bound_summary()
(since that requires running gs_update_ahr() on the new alphas).
jdblischak
jdblischak approved these changes May 1, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@jdblischak jdblischak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated gs_bound_summary() in 1ff3537

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jdblischak jdblischak jdblischak approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove "Time" from the updated design gt-summary table

2 participants

@LittleBeannie @jdblischak