<fix>[storage]: 标识注册存储需重置VG UUID#4606
Open
ZStack-Robot wants to merge 1 commit into
Open
Conversation
Resolves: ZSV-12725 Change-Id: I6a70746b7a736d61666964686278786d6e656a6e
WalkthroughChanges主存储发现结果扩展
Estimated code review effort: 2 (Simple) | ~10 minutes Sequence Diagram(s)sequenceDiagram
participant 主存储发现扩展
participant PrimaryStorageManagerImpl
participant APIDiscoverStrangePrimaryStorageReply
主存储发现扩展->>PrimaryStorageManagerImpl: 返回 PrimaryStorageDiscoveryResult
PrimaryStorageManagerImpl->>APIDiscoverStrangePrimaryStorageReply: 合并 inventories
PrimaryStorageManagerImpl->>APIDiscoverStrangePrimaryStorageReply: 合并 resetVgUuidRequiredUuids
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
header/src/main/java/org/zstack/header/storage/primary/PrimaryStorageDiscoverExtensionPoint.java (1)
10-11: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win接口方法缺少 Javadoc 注释。
根据路径指令,接口方法必须配有有效的 Javadoc 注释。
discoverStrangePrimaryStorage方法签名已变更但未添加 Javadoc 说明新的PrimaryStorageDiscoveryResult返回类型及resetVgUuidRequiredUuids字段的语义。As per coding guidelines: 接口方法不应有多余的修饰符(例如
public),且必须配有有效的 Javadoc 注释。🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@header/src/main/java/org/zstack/header/storage/primary/PrimaryStorageDiscoverExtensionPoint.java` around lines 10 - 11, 为 PrimaryStorageDiscoverExtensionPoint.discoverStrangePrimaryStorage 添加有效的 Javadoc,说明 PrimaryStorageDiscoveryResult 及其 resetVgUuidRequiredUuids 字段的语义;同时保持接口方法声明不包含多余的 public 等修饰符。Source: Path instructions
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In
`@header/src/main/java/org/zstack/header/storage/primary/PrimaryStorageDiscoverExtensionPoint.java`:
- Around line 10-11: 为
PrimaryStorageDiscoverExtensionPoint.discoverStrangePrimaryStorage 添加有效的
Javadoc,说明 PrimaryStorageDiscoveryResult 及其 resetVgUuidRequiredUuids
字段的语义;同时保持接口方法声明不包含多余的 public 等修饰符。
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: f805c49a-2442-44d1-925d-330304b3f84c
📒 Files selected for processing (6)
header/src/main/java/org/zstack/header/storage/primary/APIDiscoverStrangePrimaryStorageReply.javaheader/src/main/java/org/zstack/header/storage/primary/APIDiscoverStrangePrimaryStorageReplyDoc_zh_cn.groovyheader/src/main/java/org/zstack/header/storage/primary/PrimaryStorageDiscoverExtensionPoint.javaheader/src/main/java/org/zstack/header/storage/primary/PrimaryStorageDiscoveryResult.javasdk/src/main/java/org/zstack/sdk/DiscoverStrangePrimaryStorageResult.javastorage/src/main/java/org/zstack/storage/primary/PrimaryStorageManagerImpl.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: ZSV-12725
Change-Id: I6a70746b7a736d61666964686278786d6e656a6e
sync from gitlab !10578