Skip to content

<fix>[storage]: 标识注册存储需重置VG UUID#4606

Open
ZStack-Robot wants to merge 1 commit into
zsv_5.1.0from
sync/tao.gan/ZSV-12725@@2
Open

<fix>[storage]: 标识注册存储需重置VG UUID#4606
ZStack-Robot wants to merge 1 commit into
zsv_5.1.0from
sync/tao.gan/ZSV-12725@@2

Conversation

@ZStack-Robot

Copy link
Copy Markdown
Collaborator

Resolves: ZSV-12725

Change-Id: I6a70746b7a736d61666964686278786d6e656a6e

sync from gitlab !10578

Resolves: ZSV-12725

Change-Id: I6a70746b7a736d61666964686278786d6e656a6e
@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

Changes

主存储发现结果扩展

Layer / File(s) Summary
发现结果与扩展点契约
header/src/main/java/org/zstack/header/storage/primary/PrimaryStorageDiscoveryResult.java, header/src/main/java/org/zstack/header/storage/primary/PrimaryStorageDiscoverExtensionPoint.java
新增包含 inventories 与 resetVgUuidRequiredUuids 的发现结果对象,并更新扩展点回调类型。
发现结果聚合
storage/src/main/java/org/zstack/storage/primary/PrimaryStorageManagerImpl.java
管理器同时聚合扩展返回的 inventories 与 resetVgUuidRequiredUuids。
响应与 SDK 契约
header/src/main/java/org/zstack/header/storage/primary/APIDiscoverStrangePrimaryStorageReply.java, header/src/main/java/org/zstack/header/storage/primary/APIDiscoverStrangePrimaryStorageReplyDoc_zh_cn.groovy, sdk/src/main/java/org/zstack/sdk/DiscoverStrangePrimaryStorageResult.java
API 响应示例、中文字段文档和 SDK 结果对象新增 resetVgUuidRequiredUuids。

Estimated code review effort: 2 (Simple) | ~10 minutes

Sequence Diagram(s)

sequenceDiagram
  participant 主存储发现扩展
  participant PrimaryStorageManagerImpl
  participant APIDiscoverStrangePrimaryStorageReply
  主存储发现扩展->>PrimaryStorageManagerImpl: 返回 PrimaryStorageDiscoveryResult
  PrimaryStorageManagerImpl->>APIDiscoverStrangePrimaryStorageReply: 合并 inventories
  PrimaryStorageManagerImpl->>APIDiscoverStrangePrimaryStorageReply: 合并 resetVgUuidRequiredUuids
Loading

Suggested reviewers: taogan21

Poem

兔耳竖起看代码,
发现结果装得妙。
UUID 列表跟着跑,
响应 SDK 都知晓。
胡萝卜旁盖好章。

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed 标题明确概括了核心变更:标识注册存储需重置 VG UUID。
Description check ✅ Passed 描述与本次变更相关,包含问题单和同步来源信息。
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sync/tao.gan/ZSV-12725@@2

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
header/src/main/java/org/zstack/header/storage/primary/PrimaryStorageDiscoverExtensionPoint.java (1)

10-11: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

接口方法缺少 Javadoc 注释。

根据路径指令,接口方法必须配有有效的 Javadoc 注释。discoverStrangePrimaryStorage 方法签名已变更但未添加 Javadoc 说明新的 PrimaryStorageDiscoveryResult 返回类型及 resetVgUuidRequiredUuids 字段的语义。

As per coding guidelines: 接口方法不应有多余的修饰符(例如 public),且必须配有有效的 Javadoc 注释。

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@header/src/main/java/org/zstack/header/storage/primary/PrimaryStorageDiscoverExtensionPoint.java`
around lines 10 - 11, 为
PrimaryStorageDiscoverExtensionPoint.discoverStrangePrimaryStorage 添加有效的
Javadoc,说明 PrimaryStorageDiscoveryResult 及其 resetVgUuidRequiredUuids
字段的语义;同时保持接口方法声明不包含多余的 public 等修饰符。

Source: Path instructions

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In
`@header/src/main/java/org/zstack/header/storage/primary/PrimaryStorageDiscoverExtensionPoint.java`:
- Around line 10-11: 为
PrimaryStorageDiscoverExtensionPoint.discoverStrangePrimaryStorage 添加有效的
Javadoc,说明 PrimaryStorageDiscoveryResult 及其 resetVgUuidRequiredUuids
字段的语义;同时保持接口方法声明不包含多余的 public 等修饰符。

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: f805c49a-2442-44d1-925d-330304b3f84c

📥 Commits

Reviewing files that changed from the base of the PR and between a2e49c8 and 6907d05.

📒 Files selected for processing (6)
  • header/src/main/java/org/zstack/header/storage/primary/APIDiscoverStrangePrimaryStorageReply.java
  • header/src/main/java/org/zstack/header/storage/primary/APIDiscoverStrangePrimaryStorageReplyDoc_zh_cn.groovy
  • header/src/main/java/org/zstack/header/storage/primary/PrimaryStorageDiscoverExtensionPoint.java
  • header/src/main/java/org/zstack/header/storage/primary/PrimaryStorageDiscoveryResult.java
  • sdk/src/main/java/org/zstack/sdk/DiscoverStrangePrimaryStorageResult.java
  • storage/src/main/java/org/zstack/storage/primary/PrimaryStorageManagerImpl.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants