<fix>[console]: ZSTAC-86393 delete console proxy on shutdown#4602
Open
ZStack-Robot wants to merge 1 commit into
Open
<fix>[console]: ZSTAC-86393 delete console proxy on shutdown#4602ZStack-Robot wants to merge 1 commit into
ZStack-Robot wants to merge 1 commit into
Conversation
Backport-to: 5.4.12 Original-Jira: ZSTAC-77687 Cherry-picked-from: e3b971f Test: mvn compile -pl console -am -Dmaven.test.skip=true Resolves: ZSTAC-86393 Change-Id: Iccb5fece9a27ab5e645842526de5f3f155549853
|
Warning
|
| Layer / File(s) | Summary |
|---|---|
来宾关机事件处理 console/src/main/java/org/zstack/console/ConsoleManagerImpl.java |
ConsoleManagerImpl 实现来宾关机事件扩展点,查询虚拟机并调用控制台后端删除会话。 |
控制台清理集成验证 test/src/test/groovy/org/zstack/test/integration/console/ConsoleProxyCase.groovy |
测试通过 CloudBus 发送来宾关机消息,并轮询验证对应 ConsoleProxyVO 数量从 1 变为 0。 |
Estimated code review effort: 3 (Moderate) | ~20 minutes
Sequence Diagram(s)
sequenceDiagram
participant CloudBus
participant ConsoleManagerImpl
participant ConsoleBackend
CloudBus->>ConsoleManagerImpl: 发送来宾关机事件
ConsoleManagerImpl->>ConsoleManagerImpl: 查询并转换虚拟机
ConsoleManagerImpl->>ConsoleBackend: 删除控制台会话
Poem
小兔挥耳报关机,
控制台会话悄悄离。
消息穿过 CloudBus 门,
代理归零月光明。
测试点头蹦三蹦。
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage | Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. | Write docstrings for the functions missing them to satisfy the coverage threshold. |
✅ Passed checks (4 passed)
| Check name | Status | Explanation |
|---|---|---|
| Title check | ✅ Passed | 标题明确指出在关机时删除 console proxy,和此次变更一致。 |
| Description check | ✅ Passed | 描述说明回移删除来宾关机时的控制台代理修复,并与代码和测试变更一致。 |
| Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
✨ Finishing Touches
📝 Generate docstrings
- Create stacked PR
- Commit on current branch
🧪 Generate unit tests (beta)
- Create PR with unit tests
- Commit unit tests in branch
sync/yu.qiu/fix/ZSTAC-86393-5.4.12
Comment @coderabbitai help to get the list of available commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport ZSTAC-77687 fix for ZSTAC-86393 to 5.4.12: delete console proxy when guest shutdown event is reported.
Original Fix
Testing
mvn compile -pl console -am -Dmaven.test.skip=trueResolves: ZSTAC-86393
sync from gitlab !10574