<fix>[backport]: ZSTAC-86784 migrate storage host filters#4589
Open
zstack-robot-2 wants to merge 1 commit into
Open
<fix>[backport]: ZSTAC-86784 migrate storage host filters#4589zstack-robot-2 wants to merge 1 commit into
zstack-robot-2 wants to merge 1 commit into
Conversation
Introduce MigrateStorage host allocation semantics for storage migration so running VMs get KVM host property checks while stopped VMs skip runtime component version filtering. Resolves: ZSTAC-75332 Change-Id: I6c393d7ec962d71fb5437d7a41d0891deb7abae7
|
Warning
|
| Layer / File(s) | Summary |
|---|---|
操作契约与主存储分配 header/.../VmInstanceConstant.java, compute/.../AttachedVolumePrimaryStorageAllocatorFlow.java, compute/.../HostPrimaryStorageAllocatorFlow.java |
新增 MigrateStorage 枚举,并使附加卷及主存储分配流程采用对应的候选筛选路径。 |
主机筛选器接入 plugin/kvm/.../KVMHostAllocatorFilterExtensionPoint.java, plugin/localstorage/.../LocalStorageAllocatorFactory.java |
KVM 属性筛选支持 MigrateStorage,停止状态实例直接保留候选集;本地存储容量筛选支持该操作。 |
Estimated code review effort: 2 (Simple) | ~10 minutes
Sequence Diagram(s)
sequenceDiagram
participant VMOperation
participant PrimaryStorageAllocator
participant KVMFilter
participant LocalStorageFilter
VMOperation->>PrimaryStorageAllocator: MigrateStorage
PrimaryStorageAllocator->>KVMFilter: 筛选候选主机
PrimaryStorageAllocator->>LocalStorageFilter: 筛选本地存储容量
KVMFilter-->>PrimaryStorageAllocator: 返回候选集
LocalStorageFilter-->>PrimaryStorageAllocator: 返回候选集
Poem
小兔挥爪添新枚举,
存储迁移踏上云途。
主机筛选排成队,
停止实例候选留。
胡萝卜庆祝流程通!
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage | Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. | Write docstrings for the functions missing them to satisfy the coverage threshold. |
✅ Passed checks (4 passed)
| Check name | Status | Explanation |
|---|---|---|
| Title check | ✅ Passed | 标题简洁且准确概括了本次变更的核心:迁移存储主机过滤规则的回移。 |
| Description check | ✅ Passed | 描述明确表明这是 ZSTAC-86784 的回移,与本次变更相关。 |
| Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
✨ Finishing Touches
📝 Generate docstrings
- Create stacked PR
- Commit on current branch
🧪 Generate unit tests (beta)
- Create PR with unit tests
- Commit unit tests in branch
sync/shan.wu/fix-5.4.12-ZSTAC-86784-86786@@2
Comment @coderabbitai help to get the list of available commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport for ZSTAC-86784. Source MR: zstackio/zstack!10312.
sync from gitlab !10559