<fix>[lb]: intercept httpCompressAlgos::disable tag#4585
Conversation
Resolves: ZSTAC-81706 Change-Id: I6877637970626766686473657579617664657474 Signed-off-by: AlanJager <ye.zou@zstack.io>
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 16 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
Warning
|
Root Cause
APICreateLoadBalancerListenerMsg在 5.4.12 只校验结构化参数httpCompressAlgos,没有拦截 raw system taghttpCompressAlgos::disable。该 tag 会被持久化并传入负载均衡后端,最终生成无效的 HAProxy 配置compression algo disable。Fix Solution
Cherry-pick 原修复提交
12a4db35acfeef5c8edd7d91e9f371f5b2a1ac0a,保留原始 author、commit message、Change-Id/API-ID。适配 5.4.12:该分支没有CloudOperationsErrorCode自定义错误码机制,因此使用现有argerr(message)返回参数错误,并增加 raw system tag 回归测试。Testing
mvn -pl plugin/loadBalancer -am -DskipTests compile:BUILD SUCCESS(19 个 reactor module)systemTags=[httpCompressAlgos::disable]被拒绝,并保留正常压缩算法创建路径test模块整体test-compile被分支已有的无关编译错误阻塞:KVMHostUtilsTest与ZbsPrimaryStorageCaseResolves: ZSTAC-86787
sync from gitlab !10555