Skip to content

<fix>[lb]: intercept httpCompressAlgos::disable tag#4585

Open
zstack-robot-2 wants to merge 1 commit into
5.4.12from
sync/shixin.ruan/shixin.ruan-ZSTAC-86787
Open

<fix>[lb]: intercept httpCompressAlgos::disable tag#4585
zstack-robot-2 wants to merge 1 commit into
5.4.12from
sync/shixin.ruan/shixin.ruan-ZSTAC-86787

Conversation

@zstack-robot-2

Copy link
Copy Markdown
Collaborator

Root Cause

APICreateLoadBalancerListenerMsg 在 5.4.12 只校验结构化参数 httpCompressAlgos,没有拦截 raw system tag httpCompressAlgos::disable。该 tag 会被持久化并传入负载均衡后端,最终生成无效的 HAProxy 配置 compression algo disable

Fix Solution

Cherry-pick 原修复提交 12a4db35acfeef5c8edd7d91e9f371f5b2a1ac0a,保留原始 author、commit message、Change-Id/API-ID。适配 5.4.12:该分支没有 CloudOperationsErrorCode 自定义错误码机制,因此使用现有 argerr(message) 返回参数错误,并增加 raw system tag 回归测试。

Testing

  • mvn -pl plugin/loadBalancer -am -DskipTests compile:BUILD SUCCESS(19 个 reactor module)
  • 新增集成测试,覆盖 systemTags=[httpCompressAlgos::disable] 被拒绝,并保留正常压缩算法创建路径
  • test 模块整体 test-compile 被分支已有的无关编译错误阻塞:KVMHostUtilsTestZbsPrimaryStorageCase

Resolves: ZSTAC-86787

sync from gitlab !10555

Resolves: ZSTAC-81706

Change-Id: I6877637970626766686473657579617664657474
Signed-off-by: AlanJager <ye.zou@zstack.io>
@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 16 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 9ffa9862-584e-4f3e-9acd-d2e21c35c1c3

📥 Commits

Reviewing files that changed from the base of the PR and between b0d29e7 and 3a772dd.

📒 Files selected for processing (2)
  • plugin/loadBalancer/src/main/java/org/zstack/network/service/lb/LoadBalancerApiInterceptor.java
  • test/src/test/groovy/org/zstack/test/integration/networkservice/provider/flat/loadbalancer/OperateLoadBalancerCase.groovy

Warning

.coderabbit.yaml has a parsing error

The CodeRabbit configuration file in this repository has a parsing error and default settings were used instead. Please fix the error(s) in the configuration file. You can initialize chat with CodeRabbit to get help with the configuration file.

💥 Parsing errors (1)
Could not fetch remote config from http://open.zstack.ai:20001/code-reviews/zstack-cloud.yaml: TimeoutError: The operation was aborted due to timeout
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sync/shixin.ruan/shixin.ruan-ZSTAC-86787

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants