expr: extend #[sqlfunc] to variadic functions and convert all eager variadics#34985

Merged

antiguru merged 33 commits intoMaterializeInc:mainfrom

antiguru:variadic_func

Mar 5, 2026

Member

antiguru commented Feb 12, 2026 •

edited

Loading

Add the EagerVariadicFunc trait with a blanket LazyVariadicFunc implementation, and extend the #[sqlfunc] proc macro to generate EagerVariadicFunc implementations for variadic functions.
Convert all 30 eager variadic functions from hand-written dispatch to #[sqlfunc]-derived implementations, then extend derive_variadic! to generate the full VariadicFunc dispatch.

Best viewed commit-by-commit.

🤖 Generated with Claude Code

github-actions bot commented Feb 12, 2026

Pre-merge checklist

The PR title is descriptive and will make sense in the git log.
This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.
This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).

antiguru force-pushed the variadic_func branch 2 times, most recently from 6c22a17 to e9ed7e2 Compare

February 19, 2026 13:02

antiguru force-pushed the variadic_func branch from d59427b to ac8fb59 Compare

February 26, 2026 19:08

antiguru changed the title ~~expr: refactor VariadicFunc to trait-based dispatch with typed inputs~~ expr: extend #[sqlfunc] to variadic functions and convert all eager variadics

antiguru requested a review from ggevay

February 26, 2026 20:30

antiguru marked this pull request as ready for review

February 26, 2026 20:30

antiguru requested a review from a team as a code owner

February 26, 2026 20:30

antiguru commented

View reviewed changes

src/expr/src/scalar/func/variadic.rs Outdated Show resolved Hide resolved

antiguru force-pushed the variadic_func branch from ac8fb59 to d59427b Compare

February 26, 2026 22:06

antiguru requested a review from a team as a code owner

February 26, 2026 22:06

antiguru force-pushed the variadic_func branch 6 times, most recently from 078bc59 to d695205 Compare

February 27, 2026 13:24

ggevay reviewed

View reviewed changes

Contributor

ggevay left a comment

Looks good to me overall, wrote some comments.

src/expr-derive-impl/src/sqlfunc.rs Show resolved Hide resolved

src/expr/src/scalar/func/variadic.rs Outdated Show resolved Hide resolved

src/expr/src/scalar/func/variadic.rs Outdated Show resolved Hide resolved

src/expr/src/scalar/func/variadic.rs Outdated Show resolved Hide resolved

src/expr/src/scalar/func/variadic.rs Outdated Show resolved Hide resolved

src/expr/src/scalar/func/variadic.rs Show resolved Hide resolved

src/expr/src/scalar/func/variadic.rs Outdated Show resolved Hide resolved

src/expr-derive-impl/src/sqlfunc.rs Show resolved Hide resolved

src/expr/src/scalar/func/variadic.rs Show resolved Hide resolved

src/expr/src/scalar/func/variadic.rs Outdated Show resolved Hide resolved

antiguru force-pushed the variadic_func branch 2 times, most recently from 494af7f to c7f250e Compare

March 3, 2026 09:03

antiguru requested a review from ggevay

March 3, 2026 09:03

antiguru force-pushed the variadic_func branch 3 times, most recently from 9a3710d to ebd0c52 Compare

March 3, 2026 14:10

ggevay approved these changes

View reviewed changes

Contributor

ggevay left a comment

LGTM, I have just one minor comment left for list_slice_linear.

antiguru and others added 5 commits

March 5, 2026 16:21


          expr: add EagerVariadicFunc trait and extend #[sqlfunc] for variadic …

d6820c8

…functions

Add the `EagerVariadicFunc` trait and a blanket `LazyVariadicFunc`
implementation that bridges eager evaluation with the existing lazy
dispatch. Extend the `#[sqlfunc]` proc macro to generate
`EagerVariadicFunc` implementations for variadic functions.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Moritz Hoffmann <mh@materialize.com>


          expr: convert Replace to #[sqlfunc]

43305cc

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>


          expr: convert Translate to #[sqlfunc]

a6af9fd

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>


          expr: convert Concat to #[sqlfunc]

40c884f

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Moritz Hoffmann <mh@materialize.com>


          expr: convert ConcatWs to #[sqlfunc]

71228d0

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

antiguru and others added 26 commits

March 5, 2026 16:21


          expr: convert DateDiffDate to #[sqlfunc]

043fe2b

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>


          expr: convert DateDiffTime to #[sqlfunc]

ce08b3e

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>


          expr: convert DateDiffTimestamp and DateDiffTimestampTz to #[sqlfunc]

1ff3c9a

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Moritz Hoffmann <mh@materialize.com>


          expr: convert HmacString and HmacBytes to #[sqlfunc]

96cb22f

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Moritz Hoffmann <mh@materialize.com>


          expr: convert PadLeading to #[sqlfunc]

ac8b90d

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Moritz Hoffmann <mh@materialize.com>


          expr: convert DateBinTimestamp, DateBinTimestampTz, and TimezoneTime …

66ff66d

…to #[sqlfunc]

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Moritz Hoffmann <mh@materialize.com>


          expr: convert MakeAclItem to #[sqlfunc]

07dc237

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>


          expr: convert MakeMzAclItem to #[sqlfunc]

3d82b60

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Moritz Hoffmann <mh@materialize.com>


          expr: convert MakeTimestamp to #[sqlfunc]

87f5f46

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Moritz Hoffmann <mh@materialize.com>


          expr: convert RegexpReplace to #[sqlfunc]

6707fe9

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Moritz Hoffmann <mh@materialize.com>


          expr: convert JsonbBuildObject to #[sqlfunc]

3b85f5e

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Moritz Hoffmann <mh@materialize.com>


          expr: convert JsonbBuildArray to #[sqlfunc]

2b1cbf1

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Moritz Hoffmann <mh@materialize.com>


          expr: convert ArrayPosition to #[sqlfunc]

8555a0f

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Moritz Hoffmann <mh@materialize.com>


          expr: convert RegexpMatch to #[sqlfunc]

39c7976

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Moritz Hoffmann <mh@materialize.com>


          expr: convert RegexpSplitToArray to #[sqlfunc]

a3af46a

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Moritz Hoffmann <mh@materialize.com>


          expr: convert StringToArray to #[sqlfunc]

2d33d73

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Moritz Hoffmann <mh@materialize.com>


          expr: convert ListIndex to #[sqlfunc]

2af1c84

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Moritz Hoffmann <mh@materialize.com>


          expr: convert ListSliceLinear to #[sqlfunc]

d317dd1

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Moritz Hoffmann <mh@materialize.com>


          expr: convert ArrayFill to #[sqlfunc]

12655de

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>


          expr: convert ArrayIndex to #[sqlfunc]

cb67feb

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Moritz Hoffmann <mh@materialize.com>


          expr: convert ArrayToString to #[sqlfunc]

60a2f8d

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Moritz Hoffmann <mh@materialize.com>


          expr: convert MapBuild to #[sqlfunc]

a5c5583

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Moritz Hoffmann <mh@materialize.com>


          expr: convert ListCreate and RecordCreate to #[sqlfunc]

3613a3c

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Moritz Hoffmann <mh@materialize.com>


          expr: convert ArrayCreate to #[sqlfunc]

227c02c

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Moritz Hoffmann <mh@materialize.com>


          expr: generate VariadicFunc dispatch via derive_variadic! macro

72fbdce

Extend `derive_variadic!` to generate the full `impl VariadicFunc`
block (eval, output_type, propagates_nulls, introduces_nulls,
could_error, is_monotone, is_associative, is_infix_op) by delegating
to `LazyVariadicFunc` trait methods. Remove the hand-written dispatch
that duplicated per-variant logic. Convert `RangeCreate` to
`EagerVariadicFunc`.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>


          doc: add developer guide for #[sqlfunc] macro

c0cf65c

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

antiguru force-pushed the variadic_func branch from ebd0c52 to c0cf65c Compare

March 5, 2026 15:26

Member Author

antiguru commented Mar 5, 2026

Thanks! I must have attributed your comment to the wrong source location, you're correct! I updated the list_slice_linear function.

antiguru merged commit 9c1e276 into MaterializeInc:main

126 checks passed

antiguru deleted the variadic_func branch

March 5, 2026 15:52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet