Replace List<> with Mem_root_dynamic_array for double and uint types#5238
Replace List<> with Mem_root_dynamic_array for double and uint types#5238bsrikanth-mariadb wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces Mem_root_dynamic_array, a typesafe wrapper around MEM_ROOT_DYNAMIC_ARRAY, and refactors optimizer context replay code to use it instead of standard lists. Feedback on these changes includes: directly accessing subquery_runs in dump_sql_script to avoid pointer indirection; removing a redundant and buggy sentinel check on a double in dbug_print_read_stats; adding a missing bounds check in the const overload of at(); fixing potential undefined behavior in end() when the array is empty; and correcting a misleading comment on pop().
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
4c2f345 to
813086d
Compare
813086d to
d1aaffe
Compare
No description provided.