Skip to content

Replace List<> with Mem_root_dynamic_array for double and uint types#5238

Open
bsrikanth-mariadb wants to merge 1 commit into
bb-12.3-MDEV-39368-test-replayfrom
test-replay-use-memroot-dyn-arr
Open

Replace List<> with Mem_root_dynamic_array for double and uint types#5238
bsrikanth-mariadb wants to merge 1 commit into
bb-12.3-MDEV-39368-test-replayfrom
test-replay-use-memroot-dyn-arr

Conversation

@bsrikanth-mariadb

Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces Mem_root_dynamic_array, a typesafe wrapper around MEM_ROOT_DYNAMIC_ARRAY, and refactors optimizer context replay code to use it instead of standard lists. Feedback on these changes includes: directly accessing subquery_runs in dump_sql_script to avoid pointer indirection; removing a redundant and buggy sentinel check on a double in dbug_print_read_stats; adding a missing bounds check in the const overload of at(); fixing potential undefined behavior in end() when the array is empty; and correcting a misleading comment on pop().

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread sql/opt_context_store_replay.cc Outdated
Comment thread sql/opt_context_store_replay.cc
Comment thread sql/sql_array.h
Comment thread sql/sql_array.h Outdated
Comment thread sql/sql_array.h Outdated
@bsrikanth-mariadb bsrikanth-mariadb force-pushed the test-replay-use-memroot-dyn-arr branch from 4c2f345 to 813086d Compare June 16, 2026 03:01
@bsrikanth-mariadb bsrikanth-mariadb force-pushed the test-replay-use-memroot-dyn-arr branch from 813086d to d1aaffe Compare June 16, 2026 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

1 participant