Open
Conversation
Co-authored-by: Copilot <copilot@github.com>
ronenkapelian
requested changes
Apr 28, 2026
ronenkapelian
left a comment
ronenkapelian
left a comment
There was a problem hiding this comment.
nice to have:
add to readme:
Required GitHub Secrets
The following secrets must be configured in repository settings:
ACR_URL- Azure Container Registry URL (e.g.,myregistry.azurecr.io)ACR_PUSH_USER- Username/service principal for ACRACR_PUSH_TOKEN- Password/token for ACR authentication
How Releases Work
- Commit Changes: Use conventional commits (e.g.,
feat(scaler): add feature) - Merge to Master: Release-please creates/updates a release PR
- Merge Release PR: Triggers Docker image build and push
- Automatic Tagging: Images are tagged with version and `latest
Consider adding caching to the building process:
- name: Build and Push Docker Image
uses: docker/build-push-action@v7
with:
context: ./${{ matrix.path }}
push: true
tags: '...'
cache-from: type=registry,ref=${{ secrets.ACR_URL }}/${{ env.TEAM }}/${{ matrix.path }}:buildcache
cache-to: type=registry,ref=${{ secrets.ACR_URL }}/${{ env.TEAM }}/${{ matrix.path }}:buildcache,mode=max
Ofer added something similar to opa-la mono-repo
| "scaler": "1.0.9", | ||
| "sftpgo": "1.0.0", | ||
| "sftpgo-node-exporter": "1.0.0" | ||
| } No newline at end of file |
Contributor
Author
There was a problem hiding this comment.
I fixed but when the first new release arrives, we shouldn't touch this file. That's why I added it to prettierignore
| "packages": { | ||
| "elastic-alertmanager-connector": { | ||
| "release-type": "simple", | ||
| "prerelease": false |
There was a problem hiding this comment.
Why the other images not include this parameter?
Co-authored-by: Copilot <copilot@github.com>
… into add-commitlint
Co-authored-by: Copilot <copilot@github.com>
…d-images into add-release-please Co-authored-by: Copilot <copilot@github.com>
…into add-release-please
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #4