fix(weather): fix openmeteo forecast stuck in the past

defaultmodules/weather/providers/openmeteo.js

@@ -1,5 +1,4 @@
 const Log = require("logger");
-const { getDateString } = require("../provider-utils");
 const HTTPFetcher = require("#http_fetcher");
 
 // https://www.bigdatacloud.com/docs/api/free-reverse-geocode-to-city-api
@@ -262,22 +261,15 @@ class OpenMeteoProvider {
 			precipitation_unit: "mm"
 		};
 
-		const now = new Date();
-		const startDate = new Date(now.getFullYear(), now.getMonth(), now.getDate());
-		const endDate = new Date(startDate);
-		endDate.setDate(endDate.getDate() + Math.max(0, Math.min(7, maxNumberOfDays)));
-
-		params.start_date = getDateString(startDate);
-
 		switch (this.config.type) {
 			case "hourly":
 			case "daily":
 			case "forecast":
-				params.end_date = getDateString(endDate);
+				params.forecast_days = maxNumberOfDays + 1; // Open-Meteo counts today as day 1, so maxNumberOfDays=5 needs forecast_days=6
 				break;
 			case "current":
 				params.current_weather = true;
-				params.end_date = params.start_date;
+				params.forecast_days = 1;
 				break;
 			default:
 				return "";

tests/unit/modules/default/weather/providers/openmeteo_spec.js

@@ -80,32 +80,39 @@ describe("OpenMeteoProvider", () => {
 			expect(provider.locationName).toBe("Munich, BY");
 		});
 
-		it("should build query dates from local date, not ISO UTC conversion", async () => {
-			const toISOStringSpy = vi.spyOn(Date.prototype, "toISOString").mockReturnValue("2000-01-01T00:00:00.000Z");
-			try {
-				const provider = new OpenMeteoProvider({
-					lat: 48.14,
-					lon: 11.58,
-					type: "current"
-				});
-
-				await provider.initialize();
-
-				const url = new URL(provider.fetcher.url);
-				const params = url.searchParams;
-				const now = new Date();
-				const expectedToday = [
-					now.getFullYear(),
-					String(now.getMonth() + 1).padStart(2, "0"),
-					String(now.getDate()).padStart(2, "0")
-				].join("-");
-
-				expect(params.get("start_date")).toBe(expectedToday);
-				expect(params.get("end_date")).toBe(expectedToday);
-				expect(params.get("start_date")).not.toBe("2000-01-01");
-			} finally {
-				toISOStringSpy.mockRestore();
-			}
+		it("should use forecast_days instead of static start_date/end_date", async () => {
+			const provider = new OpenMeteoProvider({
+				lat: 48.14,
+				lon: 11.58,
+				type: "current"
+			});
+
+			await provider.initialize();
+
+			const url = new URL(provider.fetcher.url);
+			const params = url.searchParams;
+
+			expect(params.get("forecast_days")).toBe("1");
+			expect(params.has("start_date")).toBe(false);
+			expect(params.has("end_date")).toBe(false);
+		});
+
+		it("should set forecast_days based on maxNumberOfDays for forecast type", async () => {
+			const provider = new OpenMeteoProvider({
+				lat: 48.14,
+				lon: 11.58,
+				type: "forecast",
+				maxNumberOfDays: 5
+			});
+
+			await provider.initialize();
+
+			const url = new URL(provider.fetcher.url);
+			const params = url.searchParams;
+
+			expect(params.get("forecast_days")).toBe("6"); // 5 days + 1
+			expect(params.has("start_date")).toBe(false);
+			expect(params.has("end_date")).toBe(false);
 		});
 	});