Add a Converter to serialize empty strings as null values#20
Open
MatthewSteeples wants to merge 1 commit intoMacross-Software:developfrom
Open
Add a Converter to serialize empty strings as null values#20MatthewSteeples wants to merge 1 commit intoMacross-Software:developfrom
MatthewSteeples wants to merge 1 commit intoMacross-Software:developfrom
Conversation
b55e241 to
2b3a5fb
Compare
Allows these values to be excluded when `IgnoreNullValues` is True
2b3a5fb to
5bc984f
Compare
Member
|
Thanks @MatthewSteeples! I really like the idea, but I'm not sure it completely works. Check out this test: JsonSerializerOptions options = new JsonSerializerOptions();
options.Converters.Add(new JsonEmptyStringToNullConverter());
string Json = JsonSerializer.Serialize(new TestClass() { Str1 = "One", Str2 = string.Empty, Str3 = null }, options);
Assert.AreEqual("{\"Str1\":\"One\",\"Str2\":null,\"Str3\":null}", Json);
options = new JsonSerializerOptions();
options.Converters.Add(new JsonEmptyStringToNullConverter());
options.IgnoreNullValues = true;
Json = JsonSerializer.Serialize(new TestClass() { Str1 = "One", Str2 = string.Empty, Str3 = null }, options);
Assert.AreEqual("{\"Str1\":\"One\"}", Json); // <-- Fails
// Actual JSON value: "{\"Str1\":\"One\",\"Str2\":null}"
private class TestClass
{
public string? Str1 { get; set; }
public string? Str2 { get; set; }
public string? Str3 { get; set; }
}That second test with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows these values to be excluded when
IgnoreNullValuesis True