fix: Add BookStack and Obsidian to periodic scheduler task_map#893
Open
vorsengineer wants to merge 1 commit intoMODSetter:mainfrom
Open
fix: Add BookStack and Obsidian to periodic scheduler task_map#893vorsengineer wants to merge 1 commit intoMODSetter:mainfrom
vorsengineer wants to merge 1 commit intoMODSetter:mainfrom
Conversation
|
Someone is attempting to deploy a commit to the Rohan Verma's projects Team on Vercel. A member of the Team first needs to authorize it. |
BookStack (`BOOKSTACK_CONNECTOR`) and Obsidian (`OBSIDIAN_CONNECTOR`) were missing from the `task_map` in `schedule_checker_task.py`. This caused periodic/scheduled indexing to silently skip these connectors even when periodic sync was enabled in the UI. The tasks (`index_bookstack_pages_task`, `index_obsidian_vault_task`) exist and are registered in `connector_tasks.py` and routed to the connectors queue in `celery_app.py` — they were just never wired into the scheduler's dispatch map. FIX MODSetter#891 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
vorsengineer
force-pushed
the
fix/periodic-scheduler-missing-connectors
branch
from
67707d9 to
9254e95
Compare
![recurseml[bot]](https://avatars.githubusercontent.com/in/1054195?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by RecurseML
🔍 Review performed on 54e56e1..67707d9
✨ No bugs found, your code is sparkling clean
✅ Files analyzed, no issues (1)
• surfsense_backend/app/tasks/celery_tasks/schedule_checker_task.py
Owner
|
@vorsengineer Thanks for your contributions. Can you please raise both PRs on the dev branch? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BOOKSTACK_CONNECTOR→index_bookstack_pages_tasktotask_mapinschedule_checker_task.pyOBSIDIAN_CONNECTOR→index_obsidian_vault_tasktotask_mapinschedule_checker_task.pyMotivation
Both BookStack and Obsidian connectors support periodic indexing in the UI (the frontend correctly saves
periodic_indexing_enabled,indexing_frequency_minutes, andnext_scheduled_at), but thecheck_periodic_schedulestask couldn't dispatch their indexing tasks because they were missing from thetask_map.The tasks exist in
connector_tasks.pyand are routed tosurfsense.connectorsqueue incelery_app.py— they were just never added to the scheduler's dispatch map.FIX #891
Test plan
connector_tasks.pyandcelery_app.py🤖 Generated with Claude Code
High-level PR Summary
This PR fixes a bug where BookStack and Obsidian connectors couldn't execute periodic indexing despite the UI allowing users to configure it. The fix adds the missing mappings for
BOOKSTACK_CONNECTORandOBSIDIAN_CONNECTORto thetask_mapdictionary in the periodic scheduler, along with the necessary imports for their indexing tasks. This allows thecheck_periodic_schedulestask to properly dispatch indexing jobs for these two connector types.⏱️ Estimated Review Time: 5-15 minutes
💡 Review Order Suggestion
surfsense_backend/app/tasks/celery_tasks/schedule_checker_task.py