fix: keep macOS cursor visible after keyboard input#5350
Open
onlyless wants to merge 1 commit into
Open
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
This change improves macOS remote desktop cursor behavior after keyboard input.
On macOS, the system may hide the cursor while typing. In Moonlight/Sunshine remote desktop sessions, the cursor can remain hidden until a large mouse movement is sent. The macOS input backend now nudges the cursor visible after keyboard input by:
The existing streaming loop also now has a macOS implementation for
enable_mouse_keys()that keeps cursor association/display visibility refreshed while streaming.Screenshot
N/A
Issues Fixed or Closed
N/A
Type of Change
Checklist
Test Plan
env npm_config_cache=/private/tmp/sunshine-npm-cache cmake --build cmake-build-macos-check --target test_sunshine sunshineenv HOME=/private/tmp/sunshine-test-home XDG_CONFIG_HOME=/private/tmp/sunshine-test-home/.config cmake-build-macos-check/tests/test_sunshine --gtest_color=yes '--gtest_filter=-AVAudioTest.*:AVAudioTest/*:Configurations/AudioTest.*:MouseInputs/MouseHIDTest.*:EncoderVariants/EncoderTest.*'