build(deps): Add SUNSHINE_SYSTEM_VULKAN_HEADERS option#5103
Merged
Conversation
Member
ReenigneArcher
left a comment
ReenigneArcher
left a comment
There was a problem hiding this comment.
No problem with this. In fact the only reason we're not using system headers here is because of Ubuntu 22.04.
Gentoo's Vulkan headers are not that old. Signed-off-by: James Le Cuirot <chewi@gentoo.org>
|
ReenigneArcher
approved these changes
May 12, 2026
Bundle ReportBundle size has no change ✅ |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5103 +/- ##
==========================================
- Coverage 17.86% 17.85% -0.01%
==========================================
Files 111 111
Lines 24005 24005
Branches 10619 10619
==========================================
- Hits 4289 4287 -2
+ Misses 16438 14579 -1859
- Partials 3278 5139 +1861
Flags with carried forward coverage won't be shown. Click here to find out more. |
fatebugs
added a commit
to fatebugs/Sunshine
that referenced
this pull request
May 14, 2026
Bug fixes: - Delay g_vdd_indices.push_back() and persist_display_count() until the new display is confirmed visible; roll back VddRemoveDisplay on failure without leaving stale index/persist state. - Free SP_DEVICE_INTERFACE_DETAIL_DATA before break in OpenDeviceHandle to avoid memory leak. - Remove duplicate and misspelled VDD_IOCTL_UNKONWN (same value as VDD_IOCTL_UPDATE). Robustness: - Replace DXGI-based enumerate_dxgi_outputs with EnumDisplayDevices-based enumerate_displays; DXGI_OUTPUT_DESC::DeviceName uses \\.\DISPLAYx format which never contains "PSCCDD0", making the old VDD-detection logic dead. - Rewrite persist_display_count to update only the vdd_display_count line in-place, preserving comments, blank lines, and config file ordering. - Use compare_exchange_strong in start_keepalive to prevent multiple threads (tray + HTTP + startup) from racing on thread creation. Security: - Add check_content_type + validate_csrf_token to addVddDisplay and removeVddDisplay POST endpoints. - Add validate_csrf_token to removeAllVddDisplays. - Fix addVddDisplay to set status=false when add_display fails. - Fix removeVddDisplay status to reflect actual result. - Add vdd::is_initialized check to removeAllVddDisplays; return proper error when driver is not available. Cleanup: - Remove unused $tp import from VirtualDisplay.vue. - Remove extra </table> tag in docs/configuration.md. fix(macos): preserve modifier state in input events (LizardByte#5102) build(macos): configure C++ standard and ICU root (LizardByte#5101) build(deps): Add SUNSHINE_SYSTEM_VULKAN_HEADERS option (LizardByte#5103) Signed-off-by: James Le Cuirot <chewi@gentoo.org> ci: remove moonlight discord release announcement (LizardByte#5099) build(deps): bump packaging/linux/flatpak/deps/shared-modules from `2dfad85` to `8c3f3cf` (LizardByte#5098) build(deps): bump packaging/linux/flatpak/deps/shared-modules Bumps [packaging/linux/flatpak/deps/shared-modules](https://github.com/flathub/shared-modules) from `2dfad85` to `8c3f3cf`. - [Commits](flathub/shared-modules@2dfad85...8c3f3cf) --- updated-dependencies: - dependency-name: packaging/linux/flatpak/deps/shared-modules dependency-version: 8c3f3cfa5a4af9a696ff0bfb3ed0eba404faaf5d dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> build(deps): bump third-party/build-deps from `cd7d45a` to `d8b1d18` (LizardByte#5097) Bumps [third-party/build-deps](https://github.com/LizardByte/build-deps) from `cd7d45a` to `d8b1d18`. - [Release notes](https://github.com/LizardByte/build-deps/releases) - [Commits](LizardByte/build-deps@cd7d45a...d8b1d18) --- updated-dependencies: - dependency-name: third-party/build-deps dependency-version: d8b1d18b7e82f8ee396bdd05e226896fa523b0df dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> fix: building without the system tray enabled (LizardByte#5092)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This new
SUNSHINE_SYSTEM_VULKAN_HEADERSdefaults toOFF. Gentoo's Vulkan headers are not that old.Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage