refactor(roles/nextcloud): parameterize OS-specific names for multi-OS support#254
Draft
danyalberchtoldlf wants to merge 2 commits into
Draft
refactor(roles/nextcloud): parameterize OS-specific names for multi-OS support#254danyalberchtoldlf wants to merge 2 commits into
danyalberchtoldlf wants to merge 2 commits into
Conversation
…S support Move the hardcoded RHEL-specific web server user/group (apache), the PHP-FPM service name (php-fpm) and the base package list out of the role logic into vars/RedHat.yml, loaded via shared/platform-variables.yml. Expose nextcloud__webserver_user, nextcloud__webserver_group and nextcloud__php_fpm_service_name as overridable variables and use them throughout the tasks, the deployed systemd services and the notify_push unit, as well as the nextcloud-update script. Guard the SELinux restorecon tasks with the selinux status fact and switch the update script's SELinux blocks to ansible_facts["os_family"]. Only vars/RedHat.yml ships, so the role still runs on RHEL only; adding a tested vars/Debian.yml is all that is needed to extend support.
…name Add meta/argument_specs.yml declaring all user-facing variables so Ansible validates required variables (nextcloud__fqdn, nextcloud__users) and types at role entry, including the new nextcloud__webserver_user, nextcloud__webserver_group and nextcloud__php_fpm_service_name. Rename the internal __nextcloud__packages to __nextcloud__required_packages for consistency with the example role's __example__required_packages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the hardcoded RHEL-specific web server user/group (apache), the PHP-FPM service name (php-fpm) and the base package list out of the role logic into vars/RedHat.yml, loaded via shared/platform-variables.yml.
Expose nextcloud__webserver_user, nextcloud__webserver_group and nextcloud__php_fpm_service_name as overridable variables and use them throughout the tasks, the deployed systemd services and the notify_push unit, as well as the nextcloud-update script.
Guard the SELinux restorecon tasks with the selinux status fact and switch the update script's SELinux blocks to ansible_facts["os_family"].
Only vars/RedHat.yml ships, so the role still runs on RHEL only; adding a tested vars/Debian.yml is all that is needed to extend support.