axis: link _togl with -lGL (partially addresses #4034)#4042
Open
grandixximo wants to merge 1 commit into
Open
Conversation
_toglmodule.c calls raw GLX functions directly; libepoxy only provides runtime dispatch, not link-time GLX symbols. Without -lGL the resulting _togl.so has unresolved glX* symbols and fails to import on aarch64, where the transitive libepoxy -> libGL chain does not apply as it does on x86_64. Fixes the 'undefined symbol: glXDestroyContext' ImportError reported in LinuxCNC#4034. Does not fix the AXIS segfault, which appears to originate in the UTM virgl/ANGLE GL stack on Apple Silicon and is unrelated. Backport of the togl hunk from ceed26d.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_toglmodule.ccalls raw GLX (glXDestroyContextetc.). libepoxy is runtime dispatch only, does not provide link-time GLX symbols.-lGLthe built_togl.sohas 9 unresolvedglX*symbols. On x86_64 the transitive libepoxy -> libGL chain hides it; on aarch64 it fails import withundefined symbol: glXDestroyContext.Partially addresses #4034 (togl ImportError). The separate AXIS segfault on UTM/virgl/ANGLE is unrelated.
Test plan
-lGLaddslibGL.so.1to NEEDED and resolves allglX*symbols.