Fix: Memory leaks

[Piloalucard]

Summary of changes

This pull request includes following changes or fixes.

• Fixes memory leak on src/libltfs/fs.c
• Fixes memory leak on src/libltfs/xml.h by re-defining declare_tracking_arrays implementation. If called and no optional tags are required will use declare_tracking_arrays_no_opt. If called and no tags are required will use declare_tracking_arrays_no_tags
• Fixes tape_set_attribute_to_cm memory buffer wrong size.
• Fixes tape_get_attribute_from_cm memory buffer wrong size
• Deletes arch_strcpy_limited from src/libltfs/arch/ltfs_arch_ops.h
• Ensures usages for Windows/Linux implementation of arch_strcpy and arch_strncpy

Type of change

Please delete items that are not relevant.

• Refactoring
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have confirmed my fix is effective or that my feature works

[amissael95]

Please add spaces by using the next format <variable> = <value>

[Piloalucard]

Done! Thank you

[amissael95]

Why are you using now WNLTFS? Just a name preference?

[Piloalucard]

"WINLTFS" takes 7 character, and it starts writing in position 1, so it will no have space for the null character on the buffer cause it is an 8 byte buffer.
I found "WNLTFS" still accomplish the intended objective and leaves space for the null character. Do you have another proposal?

[amissael95]

Is that what you want? You are adding the header size to the pointer, an address returned by calloc, attr_data

[Piloalucard]

Yes.
Addresses are hexadecimal, integer values. Adding in this context by 1 means the address augments 1 byte as of:

• Address A = 0x09
• Address B = Null
• Address B = Address A + 1 = 0x0A

So we write starting on the first position of our given memory address, it is an offset.

We add the memory header size to start writing in the buffer after the header size, which space is being occupied by the header.

It was refactored for readability.

[amissael95]

Here you are copying the value pointer by "vender" to the "data" pointer you previously defined as the address returned by calloc + 0x5 (header size), please check and clarify.

[Piloalucard]

See explanation above.