Skip to content

chore(vscode): automated booting & logging of docker compose using vs…#188

Merged
colisee merged 4 commits intoLibreBooking:masterfrom
barakiva:automation
Mar 31, 2026
Merged

chore(vscode): automated booting & logging of docker compose using vs…#188
colisee merged 4 commits intoLibreBooking:masterfrom
barakiva:automation

Conversation

@barakiva
Copy link
Copy Markdown
Contributor

I'm too lazy to cd into the docker compose directory and run the same commands (and have them fail, search the PID of the existing containers, stop them etc) over and over. So i've wrote various docker related scripts to get things going much faster. I've also added logging (my favorite setup is detaching each logging terminal into its own window and drag them into the second monitor when debugging).

This may be too tool specific but i've seen people like the idea of .devcontainers on the main librebooking repo so I thought why not?

If this gets approved I can add podman related tasks.

@colisee
Copy link
Copy Markdown
Collaborator

colisee commented Mar 24, 2026

I am not a vscode expert and I didn't know about tasks. I tried this feature with your fork and it is very interesting.

My suggestions:

  1. Could the developer specify the librebooking image at run time?
  2. Regardless of the above, could you switch to librebooking:develop from librebooking:4.1.0 (which is not even the lastest stable version)
  3. Go ahead with podman

@barakiva
Copy link
Copy Markdown
Contributor Author

I am not a vscode expert and I didn't know about tasks. I tried this feature with your fork and it is very interesting.

My suggestions:

  1. Could the developer specify the librebooking image at run time?
  2. Regardless of the above, could you switch to librebooking:develop from librebooking:4.1.0 (which is not even the lastest stable version)
  3. Go ahead with podman
  1. Could you further detail what you mean by "specify librebooking image at run time"? If your intended behavior is switching between STABLE or DEVELOP versions of the project, it's much better to add those values at the Dockerfile and have them read from ./env/.prod.env or ./env/.dev.env than to inject dynamic values into the tasks.json (JSON is much more limited in that regard than YAML).
  2. Done
  3. Great. Will do that in a separate PR to keep this one's scope limited to just docker.

@colisee
Copy link
Copy Markdown
Collaborator

colisee commented Mar 31, 2026

I am basically OK with your PR.
Just one question: why do we have empty env/.dev.env and env/.prod.env files?

@barakiva
Copy link
Copy Markdown
Contributor Author

I am basically OK with your PR. Just one question: why do we have empty env/.dev.env and env/.prod.env files?

Based on your previous request to make image version more dynamic i've added various .env for various running profiles one might have when running the tasks but I removed them for now. I didn't really understand what you meant by "specify librebooking image at run time" but we can have a PR about this later if thats important.

@colisee colisee merged commit 508009e into LibreBooking:master Mar 31, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants