Open
Conversation
dustndus8
commented
Apr 1, 2021
PandaHun
requested changes
Apr 2, 2021
Member
PandaHun
left a comment
PandaHun
left a comment
There was a problem hiding this comment.
우선
indent 요구사항, 일급콜렉션 등 요구사항이 충족하지 않았습니다.
해당 내용 수정 부탁드립니다.
또 특이하게도 Vector를 사용했는데, C++이 익숙해서 그런건지, 아니면 자바의 Vector를 알고 사용하는지가 궁금합니다.
등 의견 첨부했으니 확인 부탁드립니다.
Member
There was a problem hiding this comment.
생성시점에 초기화 해 주는 방법도 좋은 방법일 것 같습니다
Author
There was a problem hiding this comment.
프로그래밍 요구사항-Car객체에서 해당 부분이 고정인 것 같아 그대로썼는데, 생성시점에 초기화 해주는 방법이라는 것이 어떤 것인지 잘 이해가 가지 않습니다!
dustndus8
commented
Apr 10, 2021
Comment on lines
+17
to
+22
dustndus8
commented
Apr 10, 2021
Comment on lines
+29
to
+41
dustndus8
commented
Apr 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
늦어서 죄송합니다 ㅠㅠ