Skip to content

🧹 [Code Health] Add logging to empty catch blocks in MainActivity #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LeanBitLab wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🧹 [Code Health] Add logging to empty catch blocks in MainActivity #65

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions app/src/main/java/com/leanbitlab/lwidget/MainActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@

package com.leanbitlab.lwidget

import android.util.Log
import android.Manifest
import android.appwidget.AppWidgetManager
import android.content.ComponentName
Expand Down Expand Up @@ -271,10 +272,10 @@ class MainActivity : AppCompatActivity() {
} else openAppSettings()
}
updatePermissionToggle(R.id.row_perm_data_usage, "Data Usage", !usageMissing) {
try { startActivity(Intent(android.provider.Settings.ACTION_USAGE_ACCESS_SETTINGS)) } catch (e: Exception) {}
try { startActivity(Intent(android.provider.Settings.ACTION_USAGE_ACCESS_SETTINGS)) } catch (e: Exception) { Log.e("MainActivity", "Failed to open settings", e) }
}
updatePermissionToggle(R.id.row_perm_screen_time, "Screen Time", !usageMissing) {
try { startActivity(Intent(android.provider.Settings.ACTION_USAGE_ACCESS_SETTINGS)) } catch (e: Exception) {}
try { startActivity(Intent(android.provider.Settings.ACTION_USAGE_ACCESS_SETTINGS)) } catch (e: Exception) { Log.e("MainActivity", "Failed to open settings", e) }
}
updatePermissionToggle(R.id.row_perm_weather, "Weather", !weatherMissing) {
if (weatherMissing && !isAppInstalled("org.breezyweather")) {
Expand All @@ -283,7 +284,7 @@ class MainActivity : AppCompatActivity() {
} catch (e: Exception) {
try {
CustomTabsIntent.Builder().build().launchUrl(this@MainActivity, android.net.Uri.parse("https://f-droid.org/packages/org.breezyweather/"))
} catch (e2: Exception) {}
} catch (e2: Exception) { Log.e("MainActivity", "Failed to open link", e2) }
}
} else if (weatherMissing) {
ActivityCompat.requestPermissions(this, arrayOf("org.breezyweather.READ_PROVIDER"), 104)
Expand Down Expand Up @@ -955,7 +956,7 @@ class MainActivity : AppCompatActivity() {
).setAction("Install") {
try {
CustomTabsIntent.Builder().build().launchUrl(this@MainActivity, android.net.Uri.parse("https://github.com/breezy-weather/breezy-weather/releases"))
} catch (e: Exception) {}
} catch (e: Exception) { Log.e("MainActivity", "Failed to open release link", e) }
}.show()
return@setOnCheckedChangeListener
}
Expand Down Expand Up @@ -1011,7 +1012,7 @@ class MainActivity : AppCompatActivity() {
getString(R.string.perm_usage_access_title),
com.google.android.material.snackbar.Snackbar.LENGTH_LONG
).show()
} catch (e: Exception) {}
} catch (e: Exception) { Log.e("MainActivity", "Failed to show Snackbar", e) }
return@setOnCheckedChangeListener
}
if (!checkLimit()) {
Expand Down Expand Up @@ -1126,7 +1127,7 @@ class MainActivity : AppCompatActivity() {
getString(R.string.perm_usage_access_title),
com.google.android.material.snackbar.Snackbar.LENGTH_LONG
).show()
} catch (e: Exception) {}
} catch (e: Exception) { Log.e("MainActivity", "Failed to show Snackbar", e) }
return@setOnCheckedChangeListener
}
if (!checkLimit()) {
Expand Down
Loading