Skip to content

fix: resolve import backup silently failing due to deactivated widget context #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ivanwongtf wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −40
Open

fix: resolve import backup silently failing due to deactivated widget context #113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 8 additions & 40 deletions lib/widgets/settings/backup_restore_page.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,9 @@ class BackupRestorePage extends StatelessWidget {

Future<void> _confirmFileImport(
BuildContext context, AppLocalizations localizations, BackupFileEntry entry) async {
final backupService = context.read<BackupService>();
final settingsService = context.read<SettingsService>();
final appsService = context.read<AppsService>();
showDialog(
context: context,
builder: (dialogContext) => AlertDialog(
Expand All @@ -220,51 +223,16 @@ class BackupRestorePage extends StatelessWidget {
TextButton(
onPressed: () async {
Navigator.of(dialogContext).pop();
_import(context, localizations, entry.file);
try {
await backupService.importBackup(entry.file);
settingsService.reload();
await appsService.refreshState();
} catch (_) {}
},
child: const Text("Import"),
),
],
),
);
}

Future<void> _import(BuildContext context, AppLocalizations localizations, File file) async {
try {
await context.read<BackupService>().importBackup(file);
if (context.mounted) {
context.read<SettingsService>().reload();
await context.read<AppsService>().refreshState();
showDialog(
context: context,
builder: (context) => AlertDialog(
title: const Text("Import Success"),
content: Text(localizations.importSuccess),
actions: [
TextButton(
onPressed: () => Navigator.of(context).pop(),
child: const Text("OK"),
),
],
),
);
}
} catch (e) {
if (context.mounted) {
showDialog(
context: context,
builder: (context) => AlertDialog(
title: const Text("Import Failed"),
content: Text(localizations.importError(e.toString())),
actions: [
TextButton(
onPressed: () => Navigator.of(context).pop(),
child: const Text("OK"),
),
],
),
);
}
}
}
}