NLIC-2515 Add DiscountService#61
Open
v-rudkovskiy wants to merge 2 commits into
Open
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
kkorotkov
reviewed
Jun 29, 2026
kkorotkov
reviewed
Jul 14, 2026
Comment on lines
+197
to
+199
| if (isNotFound(e)) { | ||
| return null; | ||
| } |
Member
There was a problem hiding this comment.
This belongs to the business logic. If null is a legitimate response, the REST interface should handle it gracefully as well. Otherwise, the contract diverges between the Java binding and the REST interface.
kkorotkov
reviewed
Jul 14, 2026
| * @throws NetLicensingException | ||
| * any non-not-found service error | ||
| */ | ||
| public static LicenseTemplate resolveDiscount(final Context context, final String productNumber, |
Member
There was a problem hiding this comment.
Is this intended for direct use by vendors?
kkorotkov
reviewed
Jul 14, 2026
|
|
||
| private static boolean isNotFound(final ServiceException e) { | ||
| return (e.getStatusCode() == HTTP_STATUS_NOT_FOUND) | ||
| || StringUtils.startsWith(e.getMessage(), NOT_FOUND_EXCEPTION_PREFIX); |
Member
There was a problem hiding this comment.
Deprecated method: StringUtils.startsWith
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.