Skip to content

GitHub Issue 919: Add to Storage > Search for Samples removal of "More Filters" button and related code #2925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cnathe merged 3 commits into from
Mar 31, 2026
Merged

GitHub Issue 919: Add to Storage > Search for Samples removal of "More Filters" button and related code #2925

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8bb02f0
GridFilterModal finder update to include title prefix
cnathe Mar 27, 2026
354f80c
GridFilterModal finder update to include title prefix
cnathe Mar 30, 2026
14ed17b
Merge remote-tracking branch 'origin/develop' into fb_removeMoreFilte…
cnathe Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/org/labkey/test/components/ui/grids/GridFilterModal.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,12 @@ public class GridFilterModal extends ModalDialog

public GridFilterModal(WebDriver driver, UpdatingComponent linkedComponent)
{
super(new ModalDialogFinder(driver));
this(driver, linkedComponent, "Filter");
}

public GridFilterModal(WebDriver driver, UpdatingComponent linkedComponent, String titlePrefix)
{
super(new ModalDialogFinder(driver).withTitle(titlePrefix));
_linkedComponent = linkedComponent;
}

Expand Down
2 changes: 1 addition & 1 deletion src/org/labkey/test/components/ui/search/EntityFieldFilterModal.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ public class EntityFieldFilterModal extends GridFilterModal
{
public EntityFieldFilterModal(WebDriver driver, UpdatingComponent linkedComponent)
{
super(driver, linkedComponent);
super(driver, linkedComponent, "Select");
}

@Override
Expand Down
Loading