GitHub Issue 1073: Updating a List MVTC field shows array in audit for values with quotes#7593
Merged
GitHub Issue 1073: Updating a List MVTC field shows array in audit for values with quotes#7593
Conversation
labkey-susanh
approved these changes
Apr 17, 2026
|
|
||
| ColumnInfo col = ti.getColumn(FieldKey.fromParts(baseKey)); | ||
| String value = Objects.toString(entry.getValue(), ""); | ||
| Object value = entry.getValue(); |
Contributor
There was a problem hiding this comment.
This seems like a functional change. Before, if there wasn't a value, we would possibly show a change to the empty string in the audit log. From UI testing, this seems to be doing the right things, though, and I believe it's because the empty string was being treated as effectively null.
Contributor
|
Is there a test to cover this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
List mvtc values appeared as raw PostgreSQL array syntax (e.g., {val1,val2}) in the audit log. This PR converts java.sql.Array and properly formats the value to use, instead of relying on toString.
Related Pull Requests
Changes