GitHub Issue 1058: Sample Finder saved views in subfolder break after MVTC to TC conversion#7585
Open
GitHub Issue 1058: Sample Finder saved views in subfolder break after MVTC to TC conversion#7585
Conversation
|
|
||
| for (Map.Entry<Container, List<CstmView>> containerCstmViews: containerViews.entrySet()) | ||
| { | ||
| Map<String, UserSchema> schemas = new HashMap<>(); |
Contributor
There was a problem hiding this comment.
DefaultSchema caches its children schema. Grab a default schema here (user,container)
| QueryDefinition queryDef = queryDefs.get(key); | ||
| if (queryDef == null) | ||
| { | ||
| UserSchema schema = schemas.get(cstmView.getSchema()); |
Contributor
There was a problem hiding this comment.
Use the DefaultSchema here to resolve the UserSchema.
labkey-matthewb
approved these changes
Apr 16, 2026
Contributor
labkey-matthewb
left a comment
labkey-matthewb
left a comment
There was a problem hiding this comment.
Approved, see small optimization suggestion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
MVTC to TC conversion breaks subfolder views because the listener only scanned the current container. The same issue is reproducible when renaming a data type. This PR adds a new
getDatabaseCustomViewsutil that queries custom view from all product folders.Related Pull Requests
Changes