Skip to content

Encode form name#7515

Merged
labkey-matthewb merged 29 commits intodevelopfrom
fb_encodeFormName
Mar 30, 2026
Merged

Encode form name#7515
labkey-matthewb merged 29 commits intodevelopfrom
fb_encodeFormName

Conversation

@labkey-matthewb
Copy link
Copy Markdown
Contributor

@labkey-matthewb labkey-matthewb commented Mar 23, 2026

Rationale

Whereas browsers seem to have trouble property formatting multipart/form-data POSTs, we will encode form names that include these three characters: % " \

For backward compatibility we will identify encoded field names by prepending %_.

quf_name -> quf_name
quf_why"? -> %_quf_why%22%3F

Related Pull Requests

Changes

@labkey-matthewb labkey-matthewb changed the title Fb encode form name Encode form name Mar 25, 2026
@labkey-matthewb labkey-matthewb marked this pull request as ready for review March 25, 2026 16:56
@LabKey LabKey deleted a comment from github-actions bot Mar 25, 2026
Comment thread api/src/org/labkey/api/action/AbstractFileUploadAction.java
Comment thread api/src/org/labkey/api/action/BaseViewAction.java
Comment thread api/src/org/labkey/api/assay/AssayFileWriter.java
Comment thread api/src/org/labkey/api/util/PageFlowUtil.java
Comment thread api/src/org/labkey/api/util/PageFlowUtil.java
Comment thread query/src/org/labkey/query/controllers/QueryController.java
Comment thread api/src/org/labkey/api/util/PageFlowUtil.java Outdated
Comment thread api/src/org/labkey/api/query/QueryUpdateForm.java
Comment thread api/src/org/labkey/api/dataiterator/DataIteratorUtil.java
Comment thread api/src/org/labkey/api/util/PageFlowUtil.java
@labkey-matthewb labkey-matthewb merged commit b1719f2 into develop Mar 30, 2026
6 of 13 checks passed
@labkey-matthewb labkey-matthewb deleted the fb_encodeFormName branch March 30, 2026 22:06
labkey-matthewb added a commit to LabKey/testAutomation that referenced this pull request Mar 30, 2026
#### Rationale
Support an encoding scheme for INPUT.name to avoid problems with
multipart/form-data

#### Related Pull Requests
- LabKey/labkey-api-js#211
- LabKey/labkey-ui-components#1961
- LabKey/labkey-ui-premium#916
- LabKey/limsModules#2061
- LabKey/platform#7515
- #2923

#### Changes
- <!-- list of descriptions of changes that are worth noting (replace
this comment) -->

---------

Co-authored-by: labkey-nicka <nickk@labkey.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants