Add named views to export command#1248
Open
alteous wants to merge 1 commit into
Open
Conversation
alteous
commented
Jun 19, 2026
| pub format: OutputFormat3d, | ||
| /// Named viewpoints. | ||
| #[builder(default)] | ||
| pub views: HashMap<String, CameraViewState>, |
Contributor
Author
There was a problem hiding this comment.
I have reused CameraViewState for the time being but I'm wondering whether to create a separate data structure instead. In particular, I take issue with the coordinate system being present and fields for perspective projection being mixed with those for an orthographic projection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.