Skip to content

JS: Fix Uncaught ReferenceError convertkit#1030

Merged
n7studios merged 1 commit intomainfrom
fix-uncaught-reference-error-frontend-js
Feb 25, 2026
Merged

JS: Fix Uncaught ReferenceError convertkit#1030
n7studios merged 1 commit intomainfrom
fix-uncaught-reference-error-frontend-js

Conversation

@n7studios
Copy link
Contributor

Summary

Fixes an uncaught ReferenceError due to bundling frontend JS into a single file, and the convertkit object not always being available i.e. when the user is in the WordPress Administration interface.

Screenshot 2026-02-24 at 13 43 14

Testing

Existing tests pass.

Checklist

@n7studios n7studios self-assigned this Feb 24, 2026
@n7studios n7studios added the bug label Feb 24, 2026
@github-actions
Copy link

WordPress Playground

🚀 Your PR has been built and is ready for testing in WordPress Playground!

Click here to test your changes in WordPress Playground

@n7studios n7studios requested review from a team, ciccio-kit and noelherrick and removed request for a team February 24, 2026 07:14
@n7studios n7studios marked this pull request as ready for review February 24, 2026 07:14
Copy link

@ciccio-kit ciccio-kit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

Copy link

@ciccio-kit ciccio-kit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: do we have any way to track these console errors? I'm only wondering whether or not we are losing visibility on potential issues where convertkit is not expected to be undefined

@n7studios
Copy link
Contributor Author

question: do we have any way to track these console errors? I'm only wondering whether or not we are losing visibility on potential issues where convertkit is not expected to be undefined

Not that I'm aware of. End to end tests test the functionality of scripts to ensure they're performing as expected. This wasn't a blocking bug that caused issues, though.

@n7studios n7studios merged commit 385b32b into main Feb 25, 2026
154 of 160 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants