Skip to content

Rename variable_part_dimensions to inner_variable_dimensions in Coclustering results#568

Merged
tramora merged 1 commit intomainfrom
552-refactor-coclustering-inner-variables
Apr 3, 2026
Merged

Rename variable_part_dimensions to inner_variable_dimensions in Coclustering results#568
tramora merged 1 commit intomainfrom
552-refactor-coclustering-inner-variables

Conversation

@tramora
Copy link
Copy Markdown
Collaborator

@tramora tramora commented Mar 25, 2026 •
edited
Loading

  • test_coclustering_results_simple_initializations remains unchanged
  • the CoclusteringDimension docstring is amended to give more details on "Instance * Variables Coclustering"

Fixes #552

The docstring amendment in CoclusteringDimension for inner_variable_dimensions is far from perfect and may need correction

TODO Before Asking for a Review

  • Rebase your branch to the latest version of main (or main-v10)
  • Make sure all CI workflows are green
  • When adding a public feature/fix: Update the Unreleased section of CHANGELOG.md (no date)
  • Self-Review: Review "Files Changed" tab and fix any problems you find
  • API Docs (only if there are changes in docstrings, rst files or samples):
    • Check the docs build without warning: see the log of the API Docs workflow
    • Check that your changes render well in HTML: download the API Docs artifact and open index.html
    • If there are any problems it is faster to iterate by building locally the API Docs

@tramora tramora requested a review from popescu-v March 25, 2026 15:54
popescu-v
popescu-v reviewed Mar 25, 2026
View reviewed changes
popescu-v
popescu-v reviewed Mar 25, 2026
View reviewed changes
popescu-v
popescu-v requested changes Mar 25, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@popescu-v popescu-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two docstring changes (see the comments).

@tramora tramora force-pushed the 552-refactor-coclustering-inner-variables branch from 5d917d5 to ae8ee70 Compare March 25, 2026 16:18
Rename variable_part_dimensions to inner_variable_dimensions in C…
6ddf11a 
…oclustering results

- `test_coclustering_results_simple_initializations` remains unchanged
- the `CoclusteringDimension` docstring is amended to give more details on "Instances x Variables Coclustering"
@tramora tramora force-pushed the 552-refactor-coclustering-inner-variables branch from ae8ee70 to 6ddf11a Compare March 25, 2026 16:36
@tramora tramora requested a review from popescu-v March 25, 2026 16:38
popescu-v
popescu-v approved these changes Apr 1, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@popescu-v popescu-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tramora tramora merged commit 0129d20 into main Apr 3, 2026
18 checks passed
@tramora tramora deleted the 552-refactor-coclustering-inner-variables branch April 3, 2026 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@popescu-v popescu-v popescu-v approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make the Instance-Variable Coclustering Inner Variables API More Easily Discoverable

2 participants

@tramora @popescu-v