Skip to content

Expose keep_selected_variables_only for sklearn predictors (KhiopsClassifier and KhiopsRegressor)#567

Merged
tramora merged 1 commit intomainfrom
559-expose-keep-selected-variables-only
Apr 3, 2026
Merged

Expose keep_selected_variables_only for sklearn predictors (KhiopsClassifier and KhiopsRegressor)#567
tramora merged 1 commit intomainfrom
559-expose-keep-selected-variables-only

Conversation

@tramora
Copy link
Copy Markdown
Collaborator

@tramora tramora commented Mar 23, 2026

Fixes #559


TODO Before Asking for a Review

  • Rebase your branch to the latest version of main (or main-v10)
  • Make sure all CI workflows are green
  • When adding a public feature/fix: Update the Unreleased section of CHANGELOG.md (no date)
  • Self-Review: Review "Files Changed" tab and fix any problems you find
  • API Docs (only if there are changes in docstrings, rst files or samples):
    • Check the docs build without warning: see the log of the API Docs workflow
    • Check that your changes render well in HTML: download the API Docs artifact and open index.html
    • If there are any problems it is faster to iterate by building locally the API Docs

@tramora tramora requested a review from popescu-v March 23, 2026 15:41
CHANGELOG.md Outdated
## Unreleased

### Added
- (`sklearn`) `keep_selected_variables_only` parameter to the predictors (KhiopsClassifier and KhiopsRegressor)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enclose the estimator class names within back-ticks.

Copy link
Copy Markdown
Collaborator

@popescu-v popescu-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a minor comment.

@tramora tramora force-pushed the 559-expose-keep-selected-variables-only branch from 1070020 to b5b2062 Compare April 3, 2026 14:01
@tramora tramora merged commit 9de474c into main Apr 3, 2026
13 checks passed
@tramora tramora deleted the 559-expose-keep-selected-variables-only branch April 3, 2026 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expose Core API keep_selected_variables_only to the Sklearn API

2 participants