NET-1329 simplify cache TTL to module const and per-call override#112
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
…/netra-sdk-js into NET-1329-simplify-cache-ttl
Assert PROMPT_CACHE_TTL_SECONDS expiry when cacheTtl is omitted, and stop passing the removed Config option in models client tests. Co-authored-by: Cursor <cursoragent@cursor.com>
akash-vijay-kv
approved these changes
Jul 10, 2026
AkhileshNair2201
added a commit
that referenced
this pull request
Jul 13, 2026
* feat: add opt-in TTL caching for getPrompt Co-authored-by: Cursor <cursoragent@cursor.com> * fix: downgrade vitest for Node 18 and tighten cache tests Use Vitest 3.x so dev test runs align with engines.node >=18, and add getPrompt cacheTtl integration coverage plus shutdown re-init behavior. Co-authored-by: Cursor <cursoragent@cursor.com> * feat(models): add getModelPricing with opt-in TTL cache * test(models): cover getModelPricing HTTP client failure paths Co-authored-by: Cursor <cursoragent@cursor.com> * NET-1329 simplify cache TTL to module const and per-call override (#112) * NET-1329 simplify cache TTL to module const and per-call override Co-authored-by: Cursor <cursoragent@cursor.com> * test: cover prompt default TTL and drop removed cacheTtlSeconds Assert PROMPT_CACHE_TTL_SECONDS expiry when cacheTtl is omitted, and stop passing the removed Config option in models client tests. Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Cursor <cursoragent@cursor.com> * docs: document Models API and expand caching changelog Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TICKET (https://getnetra.atlassian.net/browse/NET-1329)
Summary
cacheTtlSecondsinit config andNETRA_CACHE_TTL_SECONDSenv — they were unused; callers only ever hit the default.PROMPT_CACHE_TTL_SECONDS(60); override only via per-callcacheTtl(same pattern as models’MODEL_PRICING_CACHE_TTL_SECONDS).Why
Init/env TTL added config surface without real usage. Aligning prompts with the Phase 2 models pattern keeps one clear rule: module default + per-call override.
Test plan
vitestprompts/models/shutdown/cache suitescacheTtlSeconds/NETRA_CACHE_TTL_SECONDSMade with Cursor