Bump jixia to 1.0.5 (fix max_workers TypeError)#15
Merged
Conversation
The OOM fix passed max_workers= to batch_run_jixia, but the pinned jixia 1.0.4 does not accept that argument (added in 1.0.5), so the load step failed immediately with TypeError. Bump the pin to 1.0.5, which keeps the same APIs the loader uses.
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OOM fix (#14) passes
max_workers=tobatch_run_jixia, but pinnedjixia==1.0.4doesn't accept it (added in 1.0.5) — the load step failed withTypeError: ... unexpected keyword argument 'max_workers'. Bump to 1.0.5, which preserves all APIs the loader uses (LeanProject,run_jixia,parse_name, structs).