fix(api): Catch StripeException in RefundPaymentAsync [AB#288]#295
Merged
Merged
Conversation
StripePaymentProcessor.RefundPaymentAsync previously let StripeException propagate to ErrorHandlingMiddleware, which converted every Stripe error into a generic STRIPE_UNAVAILABLE 503. Now the processor catches StripeException and returns a PaymentOperationResult failure with the actual Stripe error message, which the controller surfaces as a 400 BadRequest. Changes: [1] Wrapped refundService.CreateAsync in try/catch(StripeException) — returns failure result with ex.StripeError?.Message References: [1] [JobFlow.Infrastructure/PaymentGateways/Stripe/StripePaymentProcessor.cs:155](https://github.com/Katharix/JobFlow.API/blob/feature/288-fix-stripe-refund-exception-handling/JobFlow.Infrastructure/PaymentGateways/Stripe/StripePaymentProcessor.cs#L155)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Stripe refund errors being silently swallowed by the global error middleware. StripePaymentProcessor.RefundPaymentAsync now catches StripeException and returns a PaymentOperationResult failure with the actual Stripe error message, which the controller already surfaces as a 400 BadRequest.
Type of Change
Changes
API
efundService.CreateAsync in ry/catch(StripeException). Returns { Success = false, Message = ex.StripeError?.Message ?? ex.Message } instead of propagating to middleware.
Testing
Work Item
Closes AB#288 — child of User Story #281
Checklist