Skip to content

Resolve Aqua method ambiguity: convert(::Type{Static.{True,False,StaticInt{N}}}, ::LazyMulAdd) #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisRackauckas merged 1 commit into from
May 27, 2026
+19 −0
Merged

Resolve Aqua method ambiguity: convert(::Type{Static.{True,False,StaticInt{N}}}, ::LazyMulAdd) #128

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions src/lazymul.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,25 @@ end
::Type{LazyMulAdd{M,O,I}},
a::LazyMulAdd{M,O,I}
) where {M,O,I} = a
# Disambiguate the generic `convert(::Type{T<:Number}, ::LazyMulAdd)` above
# against Static.jl's `convert(::Type{Static.{True,False,StaticInt{N}}},
# ::Number)` methods. Aqua flags both as matching `convert(Static.True,
# ::LazyMulAdd)` etc., since `LazyMulAdd <: Number` and neither method is
# strictly more specific. Forward to `Static`'s convert on the materialized
# value so the StaticBool / StaticInt singletons come out, matching what
# Static.jl produces for any Number input.
@inline Base.convert(
::Type{Static.True},
a::LazyMulAdd{M,O,I}
) where {M,O,I} = convert(Static.True, _materialize(a))
@inline Base.convert(
::Type{Static.False},
a::LazyMulAdd{M,O,I}
) where {M,O,I} = convert(Static.False, _materialize(a))
@inline Base.convert(
::Type{Static.StaticInt{N}},
a::LazyMulAdd{M,O,I}
) where {M,O,I,N} = convert(Static.StaticInt{N}, _materialize(a))
# @inline Base.convert(::Type{LazyMulAdd{M,O,I}}, a::LazyMulAdd{M}) where {M,O,I} = a
# @inline Base.convert(::Type{LazyMulAdd{M,T,I}}, a::LazyMulAdd{M,StaticInt{O},I}) where {M,O,I,T} = a

Expand Down
Loading