Skip to content

Fix Segfault during finalization #615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stevengj merged 2 commits into from
Nov 15, 2018
Merged

Fix Segfault during finalization #615

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f084ca8
Fix Segfault during finalization
JobJob Nov 15, 2018
51e289d
Fix typo
JobJob Nov 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/pybuffer.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,13 +42,13 @@ end
Release the reference to buffer `o`
N.b. As per https://docs.python.org/3/c-api/buffer.html#c.PyBuffer_Release,
It is an error to call this function on a PyBuffer that was not obtained via
the python c-api function `PyObject_GetBuffer(), unless o.obj is a PyPtr(C_NULL)`
the python c-api function `PyObject_GetBuffer()`, unless o.obj is a PyPtr(C_NULL)
"""
function pydecref(o::PyBuffer)
# note that PyBuffer_Release sets o.obj to NULL, and
# is a no-op if o.obj is already NULL
# TODO change to `Ref{PyBuffer}` when 0.6 is dropped.
ccall(@pysym(:PyBuffer_Release), Cvoid, (Any,), o)
_finalized[] || ccall(@pysym(:PyBuffer_Release), Cvoid, (Any,), o)
o
end

Expand Down