Thread-safe garbage collection rebase#1073
Open
MilesCranmer wants to merge 3 commits into
Open
Conversation
[Diff since v1.96.3](JuliaPy/PyCall.jl@v1.96.3...v1.96.4) **Merged pull requests:** - Rename `distutils.sysconfig` to `sysconfig` (JuliaPy#1068) (@MilesCranmer) - bump to 1.96.4 (JuliaPy#1070) (@stevengj)
MilesCranmer
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1073 +/- ##
==========================================
+ Coverage 67.75% 67.76% +0.01%
==========================================
Files 20 20
Lines 2025 2029 +4
==========================================
+ Hits 1372 1375 +3
- Misses 653 654 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebased version of #883 from @marius311
My one concern is for cases where thread 1 is busy... Does that mean the GC would simply never run?