Make similar produce the same distribution when the size is the same#240
Open
raminammour wants to merge 1 commit intoJuliaParallel:masterfrom
Open
Make similar produce the same distribution when the size is the same#240raminammour wants to merge 1 commit intoJuliaParallel:masterfrom
raminammour wants to merge 1 commit intoJuliaParallel:masterfrom
Conversation
Hello,
If the user has bothered to pass an explicit distribution, respect it in `similar` arrays. This prevents behavior as below:
```
julia> dd=drand((10,10),workers(),[2,1]);
julia> ds=similar(dd);
julia> ds.indices
1x2 Array{Tuple{UnitRange{Int64},UnitRange{Int64}},2}:
(1:10, 1:5) (1:10, 6:10)
julia> dd.indices
2x1 Array{Tuple{UnitRange{Int64},UnitRange{Int64}},2}:
(1:5, 1:10)
(6:10, 1:10)
```
A smarter implementation that tries to make a judicious distribution depending on `Dims` gets complicated fast. This is the low hanging fruit.
Hope this helps!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
If the user has bothered to pass an explicit distribution, respect it in
similararrays. This prevents behavior as below:A smarter implementation that tries to make a judicious distribution depending on
Dimsgets complicated fast. This is the low hanging fruit.Hope this helps!