Remove unused perf/lu.jl benchmark script#110
Merged
ChrisRackauckas merged 2 commits intoMay 23, 2026
Merged
Conversation
The `luflop` helper used `sum((k+1):m)` for the scaling step, which sums the indices `k+1, k+2, ..., m` instead of counting the `m - k` scaling multiplications, so any GFLOPs reported by the script were systematically inflated (issue JuliaLinearAlgebra#109). The script is not referenced from the package or its test suite, so remove it rather than fixing it in place, as suggested in the issue thread. Closes JuliaLinearAlgebra#109. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
`perf/lu.jl` is being removed; replace the README reference with a link to the corresponding SciMLBenchmarks page, which covers the same comparison with a maintained benchmark. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
ChrisRackauckas
merged commit bc3bb8a
into
JuliaLinearAlgebra:master
0 of 19 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #109.
perf/lu.jldefines aluflophelper that usessum((k+1):m)for the scaling step. That sums the indicesk+1, k+2, ..., minstead of counting them - kscaling multiplications, so the GFLOPs the script prints are systematically inflated.Per the issue thread, the script isn't referenced from the package or the test suite, so this PR just removes it. The matching helper in the SciMLBenchmarks LU benchmark is being fixed separately in SciML/SciMLBenchmarks.jl PR for
fix/luflop-scaleflop-count.Test plan
]test RecursiveFactorizationstill passes (the test suite never usedperf/lu.jl).perf/lu.jlorluflopin the repo:git grep -n 'perf/lu.jl\|luflop'returns nothing.🤖 Generated with Claude Code