Skip to content

fix(parse): honor custom style structlike#463

Merged
quinnj merged 1 commit into
masterfrom
codex/issue-462-structlike-forwarding
May 26, 2026
Merged

fix(parse): honor custom style structlike#463
quinnj merged 1 commit into
masterfrom
codex/issue-462-structlike-forwarding

Conversation

@quinnj
Copy link
Copy Markdown
Member

@quinnj quinnj commented May 26, 2026

Summary

Testing

Fixes #462

Forward JSONReadStyle structlike checks to the wrapped JSONStyle so custom styles can opt foreign types out of struct materialization.

Fixes #462
@codecov
Copy link
Copy Markdown

codecov Bot commented May 26, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 90.20%. Comparing base (19025cc) to head (e269a14).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/parse.jl 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #463      +/-   ##
==========================================
- Coverage   90.26%   90.20%   -0.06%     
==========================================
  Files           7        7              
  Lines        1397     1399       +2     
==========================================
+ Hits         1261     1262       +1     
- Misses        136      137       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@quinnj quinnj closed this May 26, 2026
@quinnj quinnj reopened this May 26, 2026
@quinnj quinnj merged commit 9310c58 into master May 26, 2026
13 of 29 checks passed
@quinnj quinnj deleted the codex/issue-462-structlike-forwarding branch May 26, 2026 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JSON ignores StructUtils methods for custom JSONStyle for structlike

1 participant