Skip to content

CompatHelper: bump compat for Documenter to 1 for package docs, (keep existing compat)#525

Merged
simsurace merged 5 commits intomasterfrom
compathelper/new_version/2023-09-16-00-52-50-289-02299168519
Mar 5, 2026
Merged

CompatHelper: bump compat for Documenter to 1 for package docs, (keep existing compat)#525
simsurace merged 5 commits intomasterfrom
compathelper/new_version/2023-09-16-00-52-50-289-02299168519

Conversation

@github-actions
Copy link
Contributor

This pull request changes the compat entry for the Documenter package from 0.27 to 0.27, 1 for package docs.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@theogf theogf force-pushed the compathelper/new_version/2023-09-16-00-52-50-289-02299168519 branch from fba631a to e047f40 Compare September 16, 2023 00:52
@codecov
Copy link

codecov bot commented Sep 16, 2023

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.47%. Comparing base (a1b4c61) to head (1cc6b9c).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #525   +/-   ##
=======================================
  Coverage   94.47%   94.47%           
=======================================
  Files          52       52           
  Lines        1466     1466           
=======================================
  Hits         1385     1385           
  Misses         81       81           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@theogf
Copy link
Member

theogf commented Sep 24, 2023

It looks like with the new HTML size threshold the docs cannot be built.

@willtebbutt
Copy link
Member

It looks like with the new HTML size threshold the docs cannot be built.

Oooo fun. I wonder if this suggests that we should lower the resolution of some of our figures? My understanding of the size threshold is that it's intended to suggest to you that your page is really quite large, and is probably going to cause issues for users. Do you know if I've got that right?

@theogf
Copy link
Member

theogf commented Sep 25, 2023

It looks like with the new HTML size threshold the docs cannot be built.

Oooo fun. I wonder if this suggests that we should lower the resolution of some of our figures? My understanding of the size threshold is that it's intended to suggest to you that your page is really quite large, and is probably going to cause issues for users. Do you know if I've got that right?

Yes that's the idea. Of course there's also the solution to raise the threshold...

@willtebbutt
Copy link
Member

Ahhh yeah, that might be better. I mean, no one has complained thus far

@simsurace simsurace closed this Nov 4, 2023
@simsurace simsurace deleted the compathelper/new_version/2023-09-16-00-52-50-289-02299168519 branch November 4, 2023 16:47
@simsurace simsurace restored the compathelper/new_version/2023-09-16-00-52-50-289-02299168519 branch November 4, 2023 16:48
@simsurace simsurace reopened this Nov 4, 2023
@simsurace
Copy link
Member

Sorry, I deleted the branch by accident.

@simsurace simsurace force-pushed the compathelper/new_version/2023-09-16-00-52-50-289-02299168519 branch 2 times, most recently from 1362b85 to f46a3c4 Compare March 5, 2026 10:46
CompatHelper Julia and others added 3 commits March 5, 2026 11:46
Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
@simsurace simsurace force-pushed the compathelper/new_version/2023-09-16-00-52-50-289-02299168519 branch from f46a3c4 to 3b40760 Compare March 5, 2026 10:46
@simsurace simsurace force-pushed the compathelper/new_version/2023-09-16-00-52-50-289-02299168519 branch from 3b40760 to 8f2c10b Compare March 5, 2026 10:47
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@simsurace simsurace merged commit 652f5c9 into master Mar 5, 2026
14 of 19 checks passed
@simsurace simsurace deleted the compathelper/new_version/2023-09-16-00-52-50-289-02299168519 branch March 5, 2026 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants