RFC: Deprecate functionality to push! tuples onto DefaultDict, DefaultOrderedDict#254
Open
RFC: Deprecate functionality to push! tuples onto DefaultDict, DefaultOrderedDict#254
Conversation
…redDict * For Base.Dict, only Pairs can be pushed. * To make Default*Dicts consistent, deprecate this functionality
Current coverage is 92.76% (diff: 0.00%)@@ master #254 diff @@
==========================================
Files 31 32 +1
Lines 2485 2488 +3
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 2308 2308
- Misses 177 180 +3
Partials 0 0
|
Contributor
|
I forget, was Gadfly the only thing that broke when these were accidentally removed? Might be good to only add new deprecations after a last 0.4-compatible release is made and master goes 0.5-only, since many other packages have already dropped 0.4 support and wouldn't necessarily fix any newly introduced deprecations there. |
Member
Author
|
After thinking about this, my preference would actually be to try to add back support for creating Dicts from tuples to base. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base.Dict, onlyPairs can be pushed.Default*Dicts consistent, deprecate this functionalityThis would affect Gadfly, and in particular, fixing the deprecations would make the code somewhat less readable. (see kmsquire/Gadfly.jl@b885108)
An alternative would be to add the ability to push tuples (and maybe other possible pair datatypes) to Base Julia.