ci: don't red-fail main when coverage-badge gist push fails#76
Open
JordanCoin wants to merge 1 commit into
Open
ci: don't red-fail main when coverage-badge gist push fails#76JordanCoin wants to merge 1 commit into
JordanCoin wants to merge 1 commit into
Conversation
The "Update coverage badge" step pushes to a gist via GIST_TOKEN. When that token is expired/invalid it returns 401 and fails the whole Test (ubuntu-latest, 1.23) job, turning main CI red even though all tests pass. Mark the cosmetic badge update continue-on-error so a badge auth issue no longer red-fails the build. Note: GIST_TOKEN (a PAT with gist scope) still needs rotating to restore the badge itself. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR prevents the main CI workflow from failing when the coverage badge gist update step can’t push due to an invalid/expired GIST_TOKEN. The intent is to keep CI green when tests and coverage computation succeed, while treating the badge update as non-blocking.
Changes:
- Marks the “Update coverage badge” GitHub Actions step as
continue-on-error: true. - Adds inline comments documenting why the step is non-blocking and how to restore badge updates (rotate
GIST_TOKEN).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Main CI has been failing on every push (since #73) — but not because of tests. The
Test (ubuntu-latest, 1.23)job's "Update coverage badge" step (schneegans/dynamic-badges-action) returns 401 Unauthorized pushing to the coverage gist, which fails the whole job. Tests pass (coverage computes fine); only the badge push fails.Fix
Mark the cosmetic badge step
continue-on-error: trueso an expired/invalidGIST_TOKENno longer red-fails the build.Follow-up (needs maintainer)
The badge itself won't update until
GIST_TOKEN(a PAT withgistscope, for gist6ffe3276…) is rotated in repo secrets. This PR just stops it from breaking CI.🤖 Generated with Claude Code