Open
Conversation
With the Maven Wrapper the contributor does not need to install Maven first. It makes sure that a build is reproducible by using always the same version of Maven for the build.
Closed
keilw
requested changes
Apr 25, 2023
Member
keilw
left a comment
keilw
left a comment
There was a problem hiding this comment.
As Travis is malfunctioning (unless you pay for it) we scrapped it, so please redo this PR to fix merge conflicts if you can.
Member
|
IMHO the wrapper is not needed. Developers of the library knows perfectly how to use the Maven. Users may add it into their projects if they wish. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the Maven Wrapper the contributor does not need to install Maven first. It makes sure that a build is reproducible by using always the same version of Maven for the build.
This change is