add setting and getting config in json format#540
Merged
danthe1st merged 7 commits intoJava-Discord:mainfrom Feb 21, 2026
Merged
add setting and getting config in json format#540danthe1st merged 7 commits intoJava-Discord:mainfrom
danthe1st merged 7 commits intoJava-Discord:mainfrom
Conversation
danthe1st
requested changes
Feb 15, 2026
Member
danthe1st
left a comment
danthe1st
left a comment
There was a problem hiding this comment.
I have yet to test this but here's my initial review.
src/main/java/net/discordjug/javabot/data/config/GuildConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/net/discordjug/javabot/data/config/GuildConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/net/discordjug/javabot/data/config/ReflectionUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/net/discordjug/javabot/data/config/ReflectionUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/net/discordjug/javabot/systems/configuration/SetConfigSubcommand.java
Outdated
Show resolved
Hide resolved
danthe1st
requested changes
Feb 17, 2026
src/main/java/net/discordjug/javabot/data/config/ReflectionUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/net/discordjug/javabot/data/config/ReflectionUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/net/discordjug/javabot/systems/configuration/SetConfigSubcommand.java
Outdated
Show resolved
Hide resolved
danthe1st
requested changes
Feb 20, 2026
danthe1st
requested changes
Feb 20, 2026
Member
There was a problem hiding this comment.
The changes look good to me and testing (including with native-image) seems like this mostly works.
However, I noticed one small regression due to how you removed the property parsers: When I try to set a string, it requires a double quotes around it. This breaks things like /config set property:moderationConfig.banMessageText value:Hello 123. I added a suggestion of how that could probably be fixed but that doesn't mean you have to do it that way.
src/main/java/net/discordjug/javabot/data/config/ReflectionUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/net/discordjug/javabot/systems/configuration/SetConfigSubcommand.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changes
/config get displays the object in json format
/config set displays the object in json format and accepts json format
removed old way of displaying objects
gson registered as a bean
very amazing pr